feat: expose some config options as env variables #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1099 +/- ##
=======================================
Coverage 91.39% 91.39%
=======================================
Files 97 97
Lines 2708 2708
Branches 463 463
=======================================
Hits 2475 2475
Misses 223 223
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Confirmed it's working on a real installation. |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 20, 2022
# [2.20.0](v2.19.1...v2.20.0) (2022-03-20) ### Bug Fixes * **bluetooth-classic:** increase change detection speed ([6325937](6325937)), closes [#775](#775) * **docker:** include heatmap dependencies in image ([7cf5de1](7cf5de1)), closes [#826](#826) ### Features * **bluetooth:** add configuration options for noise filter ([85981ee](85981ee)), closes [#775](#775) * expose some config options as env variables ([#1099](#1099)) ([3ae8e9a](3ae8e9a)), closes [#1094](#1094)
|
🎉 This PR is included in version 2.20.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 20, 2022
# [3.0.0-beta.5](v3.0.0-beta.4...v3.0.0-beta.5) (2022-03-20) ### Bug Fixes * **bluetooth-classic:** increase change detection speed ([6325937](6325937)), closes [#775](#775) * **docker:** include heatmap dependencies in image ([7cf5de1](7cf5de1)), closes [#826](#826) ### Features * **bluetooth:** add configuration options for noise filter ([85981ee](85981ee)), closes [#775](#775) * expose some config options as env variables ([#1099](#1099)) ([3ae8e9a](3ae8e9a)), closes [#1094](#1094)
|
🎉 This PR is included in version 3.0.0-beta.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Adds custom environment variable mappings for use by node-config. For now, it only includes a subset of options as suggested in the issue which triggered this PR.
Note: I haven't tested these changes with a real installation yet, just on my dev machine. Will merge after I had time to do real world tests.
Checklist
If you changed code:
npm test)npm run format)If you added a new integration:
docs/integrations/docs/.vuepress/config.tsanddocs/integrations/README.mdAdditional information
Closes #1094.