Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update PULL_REQUEST_TEMPLATE.md #293

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

rmi22186
Copy link
Member

@rmi22186 rmi22186 commented Dec 12, 2022

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

Removing this template so that it does not override mParticle/.github#5 when it is approved.

Testing Plan

NA

Reference Issue

Signed-off-by: Robert Ing <ring@mparticle.com>
@rmi22186 rmi22186 requested a review from mchuangatmp December 12, 2022 21:52
@rmi22186 rmi22186 changed the base branch from main to development December 12, 2022 21:53
@mchuangatmp mchuangatmp changed the title Update PULL_REQUEST_TEMPLATE.md refactor: Update PULL_REQUEST_TEMPLATE.md Dec 12, 2022
@mchuangatmp mchuangatmp reopened this Dec 12, 2022
@mchuangatmp mchuangatmp merged commit b54c6bd into development Dec 12, 2022
@mchuangatmp mchuangatmp deleted the refactor/update-PR-template branch December 12, 2022 22:31
mparticle-automation added a commit that referenced this pull request Jan 5, 2023
## [5.49.0](v5.48.4...v5.49.0) (2023-01-05)

### Features

* Adding method to change update interval after initialization ([#301](#301)) ([e23ad37](e23ad37))
* Adding WrapperSdk, WrapperSdkVersion - adding this values to MParticleOptions and MParticle ([#295](#295)) ([fe27e48](fe27e48))

### Updates & Maintenance

* Add semgrep, mobsf static analysis ([#289](#289)) ([aab45d0](aab45d0))
* Update PULL_REQUEST_TEMPLATE.md ([#293](#293)) ([b54c6bd](b54c6bd))
* Update submodules ([f682db7](f682db7))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 5.49.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants