Appboy kit installation fails when running carthage bootstrap

[rachelhyman]

Steps to reproduce:

1. Create a new project (on Xcode 11.3) and add a Cartfile with the following contents:

github "mparticle/mparticle-apple-sdk" ~> 7.0.     
github "mparticle-integrations/mparticle-apple-integration-appboy" ~> 7.0

2. Run carthage bootstrap --platform ios --cache-builds --use-ssh in the project directory.
3. Note output:

*** Building scheme "mParticle-Appboy" in mParticle-Appboy.xcodeproj      
Build Failed     
	Task failed with exit code 65:     
	/usr/bin/xcrun xcodebuild -project      /Users/rachel.hyman/Desktop/MParticle/Carthage/Checkouts/mparticle-apple-integration-appboy/mParticle-Appboy.xcodeproj -scheme mParticle-Appboy -configuration Release -derivedDataPath      /Users/rachel.hyman/Library/Caches/org.carthage.CarthageKit/DerivedData/11.3_11C29/mparticle-apple-integration-appboy/7.15.5 -sdk iphoneos ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES archive -archivePath /var/folders/33/lsbj890n5d7d1nsr8q5wz7x40000gp/T/mparticle-apple-integration-appboy SKIP_INSTALL=YES GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=NO      CLANG_ENABLE_CODE_COVERAGE=NO STRIP_INSTALLED_PRODUCT=NO (launched in /Users/rachel.hyman/Desktop/MParticle/Carthage/Checkouts/mparticle-apple-integration-appboy)

This usually indicates that project itself failed to compile. Please check the xcodebuild log for more details: /var/folders/33/lsbj890n5d7d1nsr8q5wz7x40000gp/T/carthage-xcodebuild.VVARN0.log

In the xcodebuild log, I see the following error:

In file included from /Users/rachel.hyman/Desktop/MParticle/Carthage/Checkouts/mparticle-apple-integration-appboy/Carthage/Build/iOS/Appboy_iOS_SDK.framework/Headers/AppboyContentCards.h:6:
/Users/rachel.hyman/Desktop/MParticle/Carthage/Checkouts/mparticle-apple-integration-appboy/Carthage/Build/iOS/Appboy_iOS_SDK.framework/Headers/ABKBannerContentCardCell.h:3:9: fatal error: 'SDWebImage/SDAnimatedImageView+WebCache.h' file not found
#import <SDWebImage/SDAnimatedImageView+WebCache.h>
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
/Users/rachel.hyman/Desktop/MParticle/Carthage/Checkouts/mparticle-apple-integration-appboy/mParticle-Appboy/MPKitAppboy.m:21:17: fatal error: could not build module 'Appboy_iOS_SDK'
        #import <Appboy_iOS_SDK/Appboy-iOS-SDK-umbrella.h>
         ~~~~~~~^
2 errors generated.

It seems that the SDWebImage dependency isn't being properly pulled down. Also please note that running simply carthage bootstrap or carthage update also fail, though not with SDWebImage-related errors according to the xcodebuild log.

[peterjenkins]

Hi Rachel, thanks for the report. We have reverted the commit which caused the problem and released version 7.15.6 of the Braze kit.

Note that if you use certain flags like --no-use-binaries, Carthage will attempt to build the Braze SDK from source, which will fail due to their SDK not being open source. This is a known limitation of the Braze SDK and can be worked around if necessary as described here: Appboy/appboy-ios-sdk#85 (comment)

We've also reached out to them to suggest they add a new manifest file to their repo, which combined with an update to the kit would mitigate the need for the workaround, but so far that change has not been put in place on their side.