fix: Support capturing click ids as custom flags in commerce events #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexs-mparticle
requested changes
Oct 24, 2024
|
|
||
| const testEvent = findEventFromRequest(fetchMock.calls(), 'Test Event'); | ||
|
|
||
| const initialTimestamp = window.mParticle.getInstance()._IntegrationCapture.initialTimestamp; |
There was a problem hiding this comment.
I see you're pulling this value but not using it anywhere.
rmi22186
commented
Oct 24, 2024
Co-authored-by: Alex S <49695018+alexs-mparticle@users.noreply.github.com>
alexs-mparticle
approved these changes
Oct 24, 2024
|
alexs-mparticle
approved these changes
Oct 25, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 28, 2024
## [2.30.2](v2.30.1...v2.30.2) (2024-10-28) ### Bug Fixes * Support capturing click ids as custom flags in commerce events ([#939](#939)) ([6fb2476](6fb2476))
|
🎉 This PR is included in version 2.30.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
extendthe custom flags to include both the custom flags created bycreateEventObjectas well as what is passed by the user, with the flags passed by the user taken as priority.Testing Plan
Added unit tests for ecommerce and page view, as well as an additional for custom events.
Manually tested regular page events, pageViews, and commerce events with and without a custom flag of
Facebook.ClickId. All behavior working as expected (passed in custom flag takes priority over captured query param)Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)