Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actively Exploited CVEs displays "false" when using -simulate-os-version flag #610

Closed
mbulmer-addepar opened this issue Jul 22, 2024 · 6 comments
Labels
invalid This doesn't seem right

Comments

@mbulmer-addepar
Copy link
Contributor

While testing with the -simulate-os-version flag (thank you for this btw!), it seems Nudge will display False when passing a version of macOS that is known to have actively-exploited CVEs.

For example, running /Applications/Utilities/Nudge.app/Contents/MacOS/Nudge -simulate-os-version "14.3.1" displays this info:
Screenshot_2024-07-22_at_4_42_41 PM

Nudge recommends macOS 14.5 as expected, but it does not appear to acknowledge that 14.3.1 has two actively-exploited CVEs that were addressed in 14.4.

I'm assuming Nudge is only reading the CVE details for macOS 14.5 but it would be a nice enhancement for it to consider any updates that were issued between the latest version and what is currently installed on the device.

@erikng erikng added the invalid This doesn't seem right label Jul 22, 2024
@erikng
Copy link
Member

erikng commented Jul 22, 2024

You're misunderstanding how this logic works. Actively Exploited CVEs is based on the key from the SOFA url. You are asking it to install 14.5, which has no known active exploits.

While you are correct that 14.3.1 has active exploits, this bug report is not valid. If you are wanting a feature request to loop through ALL updates from x version through y version for active exploits, then show that as True, I kindly ask that you make another issue for that - and more importantly mark it as a feature request.

This issue gives the impression this behavior is wrong, and it is not. You are simulating a macOS version to test the that your core nudge config is correct.

@erikng erikng closed this as completed Jul 22, 2024
@mbulmer-addepar
Copy link
Contributor Author

My apologies. This was indeed meant to be a feature request and not a bug report. Thank you for clarifying.

@erikng
Copy link
Member

erikng commented Jul 23, 2024

It's an interesting feature request and one that will likely take a new thought around the sofa code. I'm willing to entertain it so please submit a feature request issue for this so I don't forget.

@erikng
Copy link
Member

erikng commented Jul 23, 2024

Gentle ping to not forget :)

@erikng
Copy link
Member

erikng commented Jul 24, 2024

I made a ticket myself.

@erikng erikng mentioned this issue Jul 24, 2024
@mbulmer-addepar
Copy link
Contributor Author

Hey! Sorry for the delay on this, and thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants