Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop with special treatment of osc cov in FitterBase #162

Closed
KSkwarczynski opened this issue Oct 11, 2024 · 0 comments · Fixed by #183
Closed

Stop with special treatment of osc cov in FitterBase #162

KSkwarczynski opened this issue Oct 11, 2024 · 0 comments · Fixed by #183
Labels
MCMC MCMC related Nu Osc/Xsec Related with neutrino interactions or oscialtions

Comments

@KSkwarczynski
Copy link
Member

For example here there is no reasson why Osc wouldn't be just anoht syst vector

MaCh3/mcmc/mcmc.cpp

Lines 170 to 198 in 60dfdff

// Propose steps for the oscillation handlers
if (osc) {
osc->proposeStep();
// Now get the likelihoods for the oscillation
osc_llh = osc->GetLikelihood();
// Add the oscillation likelihoods to the reconfigure likelihoods
llh += osc_llh;
#ifdef DEBUG
if (debug) debugFile << "LLH for oscillation handler: " << llh << std::endl;
#endif
}
// Loop over the systematics and propose the initial step
for (size_t s = 0; s < systematics.size(); ++s) {
// Could throw the initial value here to do MCMC stability studies
// Propose the steps for the systematics
systematics[s]->proposeStep();
// Get the likelihood from the systematics
syst_llh[s] = systematics[s]->GetLikelihood();
llh += syst_llh[s];
#ifdef DEBUG
if (debug) debugFile << "LLH after " << systematics[s]->getName() << " " << llh << std::endl;
#endif
}

Currently osc have special function which adds them

void FitterBase::addOscHandler(covarianceOsc * const oscf) {

The only danger with this change is that it will break expreiment specyfic.

The sooner we change this the better.

@KSkwarczynski KSkwarczynski added MCMC MCMC related Nu Osc/Xsec Related with neutrino interactions or oscialtions labels Oct 11, 2024
@KSkwarczynski KSkwarczynski linked a pull request Oct 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MCMC MCMC related Nu Osc/Xsec Related with neutrino interactions or oscialtions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant