New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When not rendering interlinks, rendered annotations may contain duplicate names #344

Closed

machow opened this issue Jun 3, 2024 · 1 comment

Owner

machow commented Jun 3, 2024

from @r-leyshon

Hi @machow not sure if this is the most appropriate issue to attach this bug we've found. Do you have any advice?
datasciencecampus/transport-network-performance#280

It looks like render_interlinks is not set to True, annotations may duplicate names. For example:

import pathlib

def f(x: pathlib.Path): ...

The annotation for x will be pathlib.pathlib.Path.

The text was updated successfully, but these errors were encountered:

This was referenced Jun 3, 2024

Refactor: clean up typing #113

Open

fix: duplicate names in annotations #345

Merged

machow closed this as completed

r-leyshon commented Jun 4, 2024

Super, thanks for the speedy turnaround! Docs are looking great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment