Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typings? #269

Closed
gossi opened this issue Jan 5, 2019 · 2 comments
Closed

Typings? #269

gossi opened this issue Jan 5, 2019 · 2 comments

Comments

@gossi
Copy link

gossi commented Jan 5, 2019

For those of us using typescript, typings would improve autocompletion for our IDEs a lot. But I'm also sure, many people have some private types already done. It's time to throw them together.

That would maybe also mean some restructuring to be more clear? Because at the moment I do this:

import { Task } from 'ember-concurrency/-task-property';

which not only doesn't exist but also feels like the wrong import. I'd prefer something like this:

import Task from 'ember-concurrency/task';

which seems more about right - just saying.

@buschtoens
Copy link
Contributor

There's already a lot of back and forth going on in #209 😜

@gossi
Copy link
Author

gossi commented Jan 5, 2019

Erf, my search only showed results from issues, not pull requests. I'm closing this one in favor of the PR.

@gossi gossi closed this as completed Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants