Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 addon conversion? #480

Closed
NullVoxPopuli opened this issue Aug 27, 2022 · 1 comment
Closed

v2 addon conversion? #480

NullVoxPopuli opened this issue Aug 27, 2022 · 1 comment

Comments

@NullVoxPopuli
Copy link

NullVoxPopuli commented Aug 27, 2022

Idk how much detail you want in this issue, but when I heard of the babel transform changes in the 2.3.2 version, I was expecting to have to modify my babel config. I later found that this happens automatically for me in the index.js -- which can certainly be a nice ability for people don't want to think about babel.

For some background, here is the process:

Here are some example "mega" PRs were v2 conversions happened (these all also switch to pnpm, so that's why the diff is massive):

But anywho -- a goal I have for ember + babel is to be able to pick and choose babel plugins for optimal output -- right now there is a bug in @babel/plugin-proposal-decorators that requires the class-properties plugin, and I'd like to omit class-properties plugins from all my apps (because browsers natively support them) -- and providing a way for consumers of ember-concurrency to opt in/out of the babel plugin would be a good step in that direction as well. :D

@machty
Copy link
Owner

machty commented Feb 4, 2024

Done #551

@machty machty closed this as completed Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants