-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doctests fail with Rust 1.65+: std::borrow::Cow size assumption no longer valid #52
Comments
Note: rust-lang/rust#105371 Seems that for rustc 1.65 and 1.66 |
I've been a bit out of the loop for a while, and so I've missed this completely. That optimization being present renders beef pretty much obsolete, though given it's regressed there isn't much for me to do now 🙃. I'll leave this issue open for posterity, and in case this gets changed back in |
I don't think that is entirely true; at the very least the lean version will remain worthwhile even when the regression is fixed. Also, I think that |
As of Rust 1.65.0, many enums are now smaller, probably because of this new optimization:
rust-lang/rust#94075
So as of Rust 1.65.0,
std::borrow::Cow
is 24 bytes in size, same asbeef::Cow
(at least on 64-bit architectures, I haven't checked 32-bit architectures).The text was updated successfully, but these errors were encountered: