stringify takes ownership instead of a reference

[meh]

Is there a reason it takes the JsonValue by value instead of by reference?

I have a Cache that contains a JsonValue which is updated in place, and every once in a while it saves it to disk as JSON, so currently I have to clone the object which sounds like an artificial requirement.

Other than the obvious loss of the nice json::stringify(2) and friends, I think it would be a win performance wise (at least for my case 🐼)

[meh]

Actually I'm partially dumb, there are JsonValue::dump and JsonValue::to_writer which kind of fit my need, but I want it to be pretty printed.

[meh]

On a tangential note to_writer should probably return an io::Result otherwise I have no way to know if the write was successful.

[meh]

Ok, I'm fully dumb and apparently also blind, there is JsonValue::pretty, except I want a to_writer that returns an io::Result and has an option to pretty print 🐼

Sorry for the stream of notifications.

[dtolnay]

On a tangential note to_writer should probably return an io::Result otherwise I have no way to know if the write was successful.

This is a separate issue (:+1: by the way) so I filed #88 to follow up.

[dtolnay]

Actually I'm partially dumb, there are JsonValue::dump and JsonValue::to_writer which kind of fit my need, but I want it to be pretty printed.

I filed #89 for pretty print to writer.

[meh]

I'll close this because since there are JsonValue::dump and JsonValue::pretty having stringify do the magical Into<JsonValue> makes a ton of sense.

[dtolnay]

Until these are fixed, if you are stuck there is always serde_json::to_writer_pretty which (1) takes a reference, (2) writes to a writer (3) prettily, and (4) returns the error 😉.

[maciejhirsz]

Sorry this took so long, been pretty busy lately, fixed with #88 and #89 (Thanks @dtolnay!)

Might need to mention in the docs for stringify that there are alternative ways to write things.