Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support native google-java-format executables #215

Open
vorburger opened this issue Mar 1, 2024 · 1 comment
Open

Support native google-java-format executables #215

vorburger opened this issue Mar 1, 2024 · 1 comment

Comments

@vorburger
Copy link
Contributor

In google/google-java-format#868 (comment) (via google/google-java-format#1045, et al), we have made "native" (non java -jar google-java-format*.jar) binaries available; the first release to include that was https://github.com/google/google-java-format/releases/tag/v1.20.0.

E.g. JoseVSeb/google-java-format-for-vs-code#17 adopted this in a VSC extension.

This can make checks a) run a bit faster, and b) avoiding requiring having a java on the PATH, which makes this hook easier to run in certain cases (example).

Would you consider adding support for this in this project?

@macisamuele
Copy link
Owner

I would be considering the option of not running the tool via java -jar prelude for versions of the tool that suport that.
We do need to make sure that this would work across OSes as well.

I'm open to contributors helping to improve the project.
Feel free to open a PR for it and I'll be prioritising reviewing and releasing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants