When specifying the version 1.10.0 in the hook args, pretty-format-java hook is not working

[siddeshbb]

I know the latest version of google-java-format 1.10.0 is used in this hook.

But when we explicitly specify the version as args in pretty-format-java hook its failing to download.

  - repo: https://github.com/macisamuele/language-formatters-pre-commit-hooks
    rev: v2.0.0
    hooks:
      - id: pretty-format-java
        args: [--autofix,--google-java-formatter-version=1.10.0]

Terminal Output:

RuntimeError: Failed to download https://github.com/google/google-java-format/releases/download/google-java-format-1.10.0/google-java-format-1.10.0-all-deps.jar. Probably the requested version, 1.10.0, is not valid or you have some network issue.

I see you are using the below url format in the code
https://github.com/google/google-java-format/releases/download/google-java-format-{version}/google-java-format-{version}-all-deps.jar

But from google java release of 1.10.0 has this below url
https://github.com/google/google-java-format/releases/download/v1.10.0/google-java-format-1.10.0-all-deps.jar

[macisamuele]

That's sad ;( ... the release link has been changed.
Up to version 1.9 the link-template was correct.

Going to fix it right away

[siddeshbb]

Thank you @macisamuele.
Just a quick question, currently the pretty-format-java hook is using the version 1.10.0 or 1.9 ?

[macisamuele]

it might be possible that is using 1.10 but not entirely sure

[stefanDeveloper]

Currently, I also face problems with JDK 16 and the version 1.9. However, with version 1.10.0 it has been fixed, see google/google-java-format#538. Therefore, I support this fix too

[macisamuele]

I'll be dedicating today some time to actually make #59 mergable and release a new version.
Sorry for the inconvenience but I got a very intense stream of days ;P

[macisamuele]

Version 2.1.0 has just been released.