You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should allow users to clearly specify what header values they expect.
This could be used to actively check if get_index is implemented correctly and returns the expected values and it could be used to improve the typing of label and group.
To do that we could allow the user to specify a typing.NamedTuple
If we use this as return value for group, this will not be correct typing, as group likely only returns a tuple with a subset of these fields. However, I think this is still better than the current typing which is Tuple[str, ...]. At least it allows the IDE to autocomplete the subfields
We could set _INDEX_HEADER as default to Tuple[str, ...]
When checking the index during creatiion, we should check that our tuple type has the same name as the dataset (otherwise the printed output might be confusing.
We should further check of the df returned by get_index has the correct column names AND the correct types per column
The text was updated successfully, but these errors were encountered:
We should allow users to clearly specify what header values they expect.
This could be used to actively check if
get_index
is implemented correctly and returns the expected values and it could be used to improve the typing oflabel
andgroup
.To do that we could allow the user to specify a
typing.NamedTuple
Notes:
group
, this will not be correct typing, asgroup
likely only returns a tuple with a subset of these fields. However, I think this is still better than the current typing which isTuple[str, ...]
. At least it allows the IDE to autocomplete the subfields_INDEX_HEADER
as default toTuple[str, ...]
get_index
has the correct column names AND the correct types per columnThe text was updated successfully, but these errors were encountered: