Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a schedule to support redis ? #24

Closed
Rwing opened this issue May 5, 2019 · 4 comments
Closed

Is there a schedule to support redis ? #24

Rwing opened this issue May 5, 2019 · 4 comments
Milestone

Comments

@Rwing
Copy link

Rwing commented May 5, 2019

No description provided.

@madelson
Copy link
Owner

madelson commented May 5, 2019

@Rwing thanks for your interest in the library.

Can you clarify a bit more what you are looking for? There are Redis-specific locking libraries out there like RedLock.net (https://github.com/samcook/RedLock.net). I'd be curious to hear if you found those other libraries problematic (e. g. maybe they have bugs, licensing, or API inadequacies)? Or perhaps you are looking for a common distributed locking abstraction to rely on which could be swapped out (something DistributedLock does not offer today but which has been asked for (#10))?

I'm not intrinsically opposed to adding Redis support to DistributedLock, but I'd want to make sure it was going to add value on top of what is already available.

@Rwing
Copy link
Author

Rwing commented May 13, 2019

Sorry for late reply.
I think this is a common distributed lock library, because it's named 'DistributedLock' 😀.
So the library should provide multiple policies for the user to decide which one to use.

@madelson
Copy link
Owner

madelson commented May 13, 2019

@Rwing thanks for responding. We do support a few different modes today, (system-global locks backed by wait handles, distributed locks, reader-writer locks, and semaphores backed by SQL server) but not Redis yet.

I am interested in adding more implementations, but I want to avoid having the library take on a ton of different dependencies (e. g. StackExchange.Redis).

Aside from Redis, some I might consider would be MySQL GetLock (https://dev.mysql.com/doc/refman/5.7/en/locking-functions.html), PostGres advisory locks (https://www.postgresql.org/docs/9.4/explicit-locking.html), or even file-based locking.

Given the relative complexity of Redis support and availability of alternatives, I'm not planning to start it at this time but I will leave this issue open to gauge demand. Let me know if this is something you would be interested in contributing.

@madelson madelson added this to the 2.0 milestone Jan 15, 2021
@Rwing
Copy link
Author

Rwing commented Jan 15, 2021

@madelson GOOD JOB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants