Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with netcoreapp1.1 #1

Open
Pinski opened this issue Feb 17, 2017 · 2 comments
Open

Not compatible with netcoreapp1.1 #1

Pinski opened this issue Feb 17, 2017 · 2 comments

Comments

@Pinski
Copy link
Contributor

Pinski commented Feb 17, 2017

Hello,

I'm trying to use this with a netcoreapp1.1 website and it is not working. It seems to only target .NETPortable. When I tried to install the NuGet package I get the following errors:

Package Yelp.Api 1.2.0 is not compatible with netcoreapp1.1 (.NETCoreApp,Version=v1.1). Package Yelp.Api 1.2.0 supports: portable45-net45+win8+wpa81 (.NETPortable,Version=v4.5,Profile=Profile111) One or more packages are incompatible with .NETCoreApp,Version=v1.1.

Package Yelp.Api 1.2.0 is not compatible with netcoreapp1.1 (.NETCoreApp,Version=v1.1) / win. Package Yelp.Api 1.2.0 supports: portable45-net45+win8+wpa81 (.NETPortable,Version=v4.5,Profile=Profile111) One or more packages are incompatible with .NETCoreApp,Version=v1.1 (win).

Package Yelp.Api 1.2.0 is not compatible with netcoreapp1.1 (.NETCoreApp,Version=v1.1) / win-x64. Package Yelp.Api 1.2.0 supports: portable45-net45+win8+wpa81 (.NETPortable,Version=v4.5,Profile=Profile111) One or more packages are incompatible with .NETCoreApp,Version=v1.1 (win-x64).

Package Yelp.Api 1.2.0 is not compatible with netcoreapp1.1 (.NETCoreApp,Version=v1.1) / win-x86. Package Yelp.Api 1.2.0 supports: portable45-net45+win8+wpa81 (.NETPortable,Version=v4.5,Profile=Profile111) One or more packages are incompatible with .NETCoreApp,Version=v1.1 (win-x86).

I inserted your code directly into my project and it seems to work fine. Any reason this is only targeting .NETPortable?

Thanks.

@Pinski Pinski changed the title Not compatible with netcoreap1.1 Not compatible with netcoreapp1.1 Feb 17, 2017
@Pinski
Copy link
Contributor Author

Pinski commented Feb 17, 2017

I ran all of your unit tests in netcoreapp1.1 and they all passed. I had to create a new version of your test project that was targeting netcoreapp1.1 though.

@madenwala
Copy link
Owner

So sorry, I didn't know that anyone had been creating issues and pull requests. Just noticed this now! Need to figure out how to get email notifications. But please go ahead and submit a pull request for this and I'll accept it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants