Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it faster #7

Open
madeso opened this issue May 28, 2019 · 0 comments
Open

Make it faster #7

madeso opened this issue May 28, 2019 · 0 comments
Labels
enhancement New feature or request less important

Comments

@madeso
Copy link
Owner

madeso commented May 28, 2019

We can't test how fast/slow this is, so some form of test is absolutely needed to compare to other json parsers and most importantly so previous builds (#26)

That being said, I guess these are some candidates for slowness:

  • the "many" shared_ptr allocations Replace shared_ptr #25
  • the horrible but easy to read and modify parser
  • the fact that there is no streaming api (by design) forcing us to read a whole file into memory before we can parse (and allocate the strings again)
@madeso madeso added enhancement New feature or request less important labels May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request less important
Projects
None yet
Development

No branches or pull requests

1 participant