Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermediate support for deprecation of types in ES 6+ #47

Closed
bslinger opened this issue Jun 7, 2018 · 3 comments
Closed

Intermediate support for deprecation of types in ES 6+ #47

bslinger opened this issue Jun 7, 2018 · 3 comments

Comments

@bslinger
Copy link

bslinger commented Jun 7, 2018

Types have been removed as of ES 6+, and the suggestion from Elastic is to re-index and store _type in a type field, as per https://www.elastic.co/blog/index-type-parent-child-join-now-future-in-elasticsearch

Is it possible there could be an intermediate version of Elastic Searcher which kept the same API for defining types, but modified the query to add a filter for that type field (configurable would probably be nice)?

@dieterve
Copy link
Contributor

Interesting, I am however not a fan of prolonging the deprecation period of elasticsearch. It seems sensible to support types for as long as elasticsearch supports it. I prefer to keep this package its API as close to elasticsearch as possible and supporting types while elasticsearch doesn't, does not fit in that strategy. That means not doing anything special in this package but requiring the end-user to implement the backwards compatibility.

@slashrsm
Copy link
Contributor

This is now done in 0.7.x branch.

@slashrsm
Copy link
Contributor

See #59 for changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants