Add isMajorScale and isMinorScale functions #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, a general helper isModal to check whether it is one of the modals and an isMode to check if it is a specific mode? Am I correct? I was wondering if we need to cover the 3 minor forms (natural, harmonic, melodic) with the isMinor check. |
|
I don't think we need the |
|
So every mode is diatonic and every diatonic scale is a mode? Wow. |
|
With the restrictions on the diatonic scale (2 half, 5 whole steps, the half steps should be either 2 or 3 full steps away from each other) there are only 7 possible options and they line up with the 7 modes. |
|
Proving my point about learning music while writing JavaScript here 👌 |
|
Closing this one as part of our cleanup efforts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
isMajorScalefunctionisMinorScalefunctionSuggestion
Since major is the ionian and minor is the aeolian mode, should we abstract an
isModefunction that allows you to pass a scale and a mode?That would require us to change the current
isModefunction to something likeisModal, which describes better what it does imho.Closes #3
Closes #18