You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Why you are renaming file zconf.h to zconf.h.included in source files? (CMakeLists.txt:77)
It is making the git revision as dirty and force users to fetch your code to build directory instead to use it as a git submodule.
I see that you already have file zconf.h.in, so why you are not using configre_file function to generate zconf.h in build directory. Then only you need to do is to add target_include_directories(${PROJECT_NAME} PUBLIC ${CMAKE_CURRENT_BINARY_DIR}). zconf.h shall then be also be removed from source code.
Please consider it ASAP
The text was updated successfully, but these errors were encountered:
I also ran into this issue, which makes my top level git repository state untracked changes and such.
This .included nonsense can't be disabled by revoking permission either because then the entire build fails!
Why you are renaming file zconf.h to zconf.h.included in source files? (CMakeLists.txt:77)
It is making the git revision as dirty and force users to fetch your code to build directory instead to use it as a git submodule.
I see that you already have file zconf.h.in, so why you are not using
configre_file
function to generate zconf.h in build directory. Then only you need to do is to addtarget_include_directories(${PROJECT_NAME} PUBLIC ${CMAKE_CURRENT_BINARY_DIR})
. zconf.h shall then be also be removed from source code.Please consider it ASAP
The text was updated successfully, but these errors were encountered: