Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot build zlib v.1.2.12 on Windows without compiler warnings #628

Closed
mrserb opened this issue Apr 4, 2022 · 1 comment
Closed

Cannot build zlib v.1.2.12 on Windows without compiler warnings #628

mrserb opened this issue Apr 4, 2022 · 1 comment

Comments

@mrserb
Copy link

mrserb commented Apr 4, 2022

This line of code in the deflate.h
s->sym_buf[s->sym_next++] = dist; \

produces then next warning:
zlib\deflate.c warning C4244: '=': conversion from 'ush' to 'uchf', possible loss of data

The warning can be supresssed by this cast:
s->sym_buf[s->sym_next++] = (uchf)dist; \
But I am not sure is it safe to do so or not.

Microsoft Visual Studio 2019 is checked.
@mrserb
Copy link
Author

mrserb commented Apr 4, 2022

Fixed 3df8424

@mrserb mrserb closed this as completed Apr 4, 2022
@Neustradamus Neustradamus mentioned this issue Jul 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrserb