Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncentered and half-height characters in terminals #95

Closed
Silejonu opened this issue Oct 19, 2022 · 8 comments
Closed

Uncentered and half-height characters in terminals #95

Silejonu opened this issue Oct 19, 2022 · 8 comments
Assignees
Milestone

Comments

@Silejonu
Copy link

Silejonu commented Oct 19, 2022

In version 1.4, characters are reduced in height and uncentered in terminal windows. This behaviour was not present in 1.3 and downwards.

I tested (and successfully reproduced) this issue in GNOME Terminal and GNOME Console, on Arch Linux and Fedora 36. Both the .ttf and .otf files are affected.

All the other applications I tested (gedit, Text Editor, LibreOffice Writer) seem unaffected.

mononoki 1.3 behaviour:
Screenshot from 2022-10-19 20-47-37

mononoki 1.4 behaviour:
Screenshot from 2022-10-19 20-39-29

@madmalik madmalik self-assigned this Oct 19, 2022
@madmalik
Copy link
Owner

Thanks for creating the issue. Is this happening for the otf version or the ttf version?

@Silejonu
Copy link
Author

Silejonu commented Oct 19, 2022

Thanks for creating the issue. Is this happening for the otf version or the ttf version?

I realised I forgot to mention it immediately after submitting the issue and edited it, but you're too quick. ^^

It happens with both the otf and ttf versions.

@datMaffin
Copy link

datMaffin commented Oct 29, 2022

Hmm. I did not yet try to reproduce this, or try to dig deeper into this issue, but just comparing the metrics, there seems to be a small change:
1.4 .ttf is on the left, the 1.3 ttf is on the right
image
The "Really use Typo metrics" checkbox seems to now be enabled.

FontForge describes the "Really use Typo metrics" field as:
image

The HHead Line Gap is also different, but according to FontForge this is only used on a mac.
However, I think that the old value of 0 makes more sense. Because the "ascent" and "decent" is already the big value of 900 and 250, adding even more spacing via the line gap seems redundant.
But I do not know how it renders on macOS, so maybe its fine.

Definitely looks weird...
It feels, though, as if with 1.4 the "Typo Ascent", "Typo Descent" and "Typo Line Gap" are now used. But it is weird that Gnome Terminal would include the "Typo Line Gap" to size its cursor.

@madmalik
Copy link
Owner

Hmm. I did not yet try to reproduce this, or try to dig deeper into this issue, but just comparing the metrics, there seems to be a small change: 1.4 .ttf is on the left, the 1.3 ttf is on the right image The "Really use Typo metrics" checkbox seems to now be enabled.

I updated glyphs from version 2 to version 3, maybe that changed some defaults. I'm gonna dig into this

@datMaffin
Copy link

datMaffin commented Nov 4, 2022

I gave the current mononoki ttf release (1.4) a try in GNOME Terminal 3.28.2 (Ubuntu 18.04), and I was not able to reproduce it:
image

@Silejonu
Copy link
Author

Silejonu commented Nov 5, 2022

I just tested on Ubuntu 22.04, and I have the same issue.

@madmalik
Copy link
Owner

madmalik commented Nov 7, 2022

I was able to reproduce the issue under Linux Mint in gnome terminal myself. I've installed FontForge and changed the "really use typo metrics" and it doesn't make a difference.

I'm gonna play around with the configuration and try if I can find out whats causing it.

Edit: It is the headline gap value that is causing the problem. Now I just have to find a way to set that in glyphs.

@felis-blue felis-blue added this to the Version 1.5 milestone Nov 7, 2022
@madmalik
Copy link
Owner

madmalik commented Nov 19, 2022

I found the relevant settings in glyphs. It ended up being both settings, that needed to be changed for it to be displayed properly: The "Really use typo metric" checkbox and the "HHead Line Gap" setting. Please nobody ask me why, it's black magic to me 😬 but should be fixed in the upcoming version! Thank you @datMaffin for nudging me in the right direction!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants