-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increasing num_generation_jobs fails #43
Comments
created new branch |
UPDATEThe workflow fails if num_generation_jobs > 6 and num_generation_jobs % 6 != 0. Basically, if we want to increase the number of jobs, we have to set num_generation_jobs to be a multiple of 6. My best guess is that this is closely related to the fact that the morphing basis is 6-dimensional. Here is a summary of what I tried with screenshots:
Screenshots |
Hi @irinaespejo , My understanding of the morphing basis is very limited, so it may be the case that, as you said, it is a 6 dimensional basis that can only scale on a factor of 6. That is something a Physics-background person should clarify. On the other hand, the piece of code you are referring to (on the |
Update: The scaling via increasing the number of jobs is being considered and tracked in this Please refer to that issue for future discussion. |
Context
The workflow fails when increasing the top-level parameter num_generation_jobs. The workflow first fails at the
delphes
stage. Usually
delphes_0
is successful and the error appears afterdelphes_1
. Once the error appears all thedelphes
stages after that one also fail.Process
Change "num_generation_jobs" in
reana/reana.yaml
for a higher number than 6.run the workflow
make reana-run
Expected result
changing the num_generation_jobs should not make the workflow fail. It should branch the generation stage accordingly and each branch should succesfully pass pythia and delphes stages.
Current result
See screenshot.
The Logs tab gives more information about
delphes_1
. The error is a KeyError inmadminer/code/delphes.py
'''
Traceback (most recent call last):
File "/madminer/code/delphes.py", line 96, in
reader.analyse_delphes_samples()
File "/usr/local/lib/python3.8/dist-packages/madminer/delphes/delphes_reader.py", line 603, in analyse_delphes_samples
this_observations, this_weights, this_n_events = self._analyse_delphes_sample(
File "/usr/local/lib/python3.8/dist-packages/madminer/delphes/delphes_reader.py", line 772, in _analyse_delphes_sample
_, this_weights = parse_lhe_file(
File "/usr/local/lib/python3.8/dist-packages/madminer/utils/interfaces/lhe.py", line 262, in parse_lhe_file
output_weights[benchmark_name] = weights_all_events[benchmark_name]
KeyError: 'sm'
'''
The rest of the
delphes_2,3,4,5,6
give similar logs but with different keys causing the error:delphes_2
: KeyError: 'w'delphes_3
: KeyError: 'morphing_basis_vector_2'delphes_4
: KeyError: 'morphing_basis_vector_3'delphes_5
: KeyError: 'morphing_basis_vector_4'delphes_6
: KeyError: 'morphing_basis_vector_5'Possible Fix
Go to debug
madminer/code/delphes.py
there must be a problem with the circular generation method: that is a modulo% 6
which has to be modified.The text was updated successfully, but these errors were encountered: