Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal of a convention about npm modules distribution. #1458

Closed
vilicvane opened this issue Aug 31, 2014 · 4 comments
Closed

Proposal of a convention about npm modules distribution. #1458

vilicvane opened this issue Aug 31, 2014 · 4 comments

Comments

@vilicvane
Copy link

See microsoft/TypeScript#575

Will this interests WebEssentials team?

@am11
Copy link
Contributor

am11 commented Aug 31, 2014

I don't think so; since WE isn't using TypeScript's npm. WE provides previewing, linting and intellisense feature for TS. Compilation is done by VS's native TS support.

@vilicvane
Copy link
Author

Hmm, I understand.

However, this feature won't need WE to handle compiling, the definition files are already compiled by the package owner, and what need to be done is just wrap up the definition files and do some little magic.

Anyway WE does compile markdown right? I think we shouldn't add that hard limit to typescript as well.

@am11
Copy link
Contributor

am11 commented Aug 31, 2014

Web Essentials doesn't intervene with compilers' business either. It consumes the output and surpluses the experience with rich features. Also, we try not to post-process or alter the generated output, unless there is a bug in upstream which is a show stopper (for instance, some CSS compilers generating incorrect paths in source-maps).

Markdown compilation is handled differently but that's besides the point. Visual Studio doesn't have built-in Markdown compilation support, so we had to use the third-party solution (MarkdownSharp, which btw is not npm either, its a .NET implementation).

I think we shouldn't add that hard limit to typescript as well

There is no limit on TypeScript imposed by WE. For compilation we simply let VS handle with its OOTB support for TypeScript, not via npm. From WE's perspective, TypeScript -- being native in VS -- has this advantage over CoffeeScript, Markdown, LiveScript, SweetJS etc.

@vilicvane
Copy link
Author

okay I got your point. but as this is proposed as a convention, I don't think VS would do anything about it. and though it gets something related compiler stuffs, it's essentially none of compiler's business.

but anyway hoping there would be a solution for typescript npm package distribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants