Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCSS compile broken with big SCSS frameworks like Bourbon Neat #1530

Open
martonx opened this issue Sep 23, 2014 · 9 comments
Open

SCSS compile broken with big SCSS frameworks like Bourbon Neat #1530

martonx opened this issue Sep 23, 2014 · 9 comments

Comments

@martonx
Copy link

martonx commented Sep 23, 2014

SCSS compile broken with big SCSS frameworks like Bourbon Neat.

To reproduce the problem please add Bourbon Neat from Nuget, then try to compile it. Nothing will be compiled, and I got only one empty error message.

@am11
Copy link
Contributor

am11 commented Sep 23, 2014

Are you testing with the nightly build?

@martonx
Copy link
Author

martonx commented Sep 23, 2014

No, but I will.

@martonx
Copy link
Author

martonx commented Sep 23, 2014

Oh, with 2.3.4 my VS is completly broke, when tried to open my Solution including Bourbon Neat. I had to go back to 2.3.0. I think I know one problem. Bourbon Neat uses only "_" prefixed .scss files.
Meanwhile I found Mindscape's Web Workbench which is handle Bourbon Neat .scss files, so at least I can work.

So please fix it asap.

@am11
Copy link
Contributor

am11 commented Sep 23, 2014

@madskristensen, @SLaks

Some folks (@martonx, @tbertenshaw, @blowsie, @RaptorCZ, @nj, @sqmgh) are complaining about the broken build (2.3.4) and subsequently crashing VS on opening the solution. I am testing with current master but unable to reproduce the said behavior.

  • Is there a major bug which has been fixed since then?
  • Can you reproduce this behavior with any of your projects?

Even the unit tests are passing (except for the sweetjs one, which is due to sweet-js/sweet-core#386).

@OniBait
Copy link

OniBait commented Oct 7, 2014

Odd. I have no problem with Bourbon Neat w/ 2.3.

@am11
Copy link
Contributor

am11 commented Oct 7, 2014

BTW, v2.3.5 nightly was released yesterday.

@samrueby
Copy link

I have been having trouble with importing standard Bourbon. I used to just get the message "Syntax Error!" with 2.3.0. Switched to nightly build last night (2.3.5), now I receive "SASS: error reading values after webkit-image". Everything compiles correctly when using native Sass.

@am11
Copy link
Contributor

am11 commented Oct 14, 2014

@samrueby,

Summary: "Don't worry, it has been fixed, the next nightly or the one after that will bring the fix to the mix".

Descriptive version:

Web Essentials is a hub of different web-technologies (super-set languages) compilers. Therefore, Web Essentials can only do much in this case. For SASS compilation support, it merely uses libsass via node-sass which Web Essentials call via npm. In this case node-sass is just a node.js wrapper around libsass.

So libsass is the real deal where the compilation is happening (its also belongs to SASS org but written is C++, as opposed to ruby-sass which is written in Ruby. Difference? C++ one is super-fast when compiling large code bases).

Ruby-sass (gem) is the most on the edge when it comes to language support. Libsass is just closer to the edge (given the difference between coding complexity in Ruby vs. C++..).

More discussion on this topic here: #1400

So the issue you are reporting belongs to libsass, which has already been reported here: sass/libsass#380 and closed in favor of sass/libsass#263, which says it was fixed some 11 days ago.

Next; node-sass will make a release in the form of npm, and when we make WE's release, it will fetch that latest npm on build and hence you will get more sass 3.x language support.

For future reference, please track the SASS' syntax-related issues in libsass issue tracker and report it there if someone hasn't done it already: https://github.com/sass/libsass/issues.

@samrueby
Copy link

Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants