Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When providing image, allow some default values #329

Closed
nfachan opened this issue Jul 8, 2024 · 1 comment
Closed

When providing image, allow some default values #329

nfachan opened this issue Jul 8, 2024 · 1 comment
Labels
all-clients Issues that affect all client programs: all test runners and maelstrom-run.
Milestone

Comments

@nfachan
Copy link
Collaborator

nfachan commented Jul 8, 2024

Especially for maelstrom-run, but probably also for test runners, it's nice to be able to shorten the image lines. I can thing of two things we should do.

First, if no use is provided, we should default to everything.

Second, if a string is provided instead of an object, we should expect the value to be thename value for the image, and we should assume a use that of everything.

@nfachan nfachan added maelstrom-run test-runners Issues that affect all test runners (cargo-maelstrom, maelstrom-pytest, maelstrom-to-test, etc.). labels Jul 8, 2024
@nfachan nfachan added this to the 0.11.0 milestone Jul 8, 2024
@nfachan nfachan added all-clients Issues that affect all client programs: all test runners and maelstrom-run. and removed test-runners Issues that affect all test runners (cargo-maelstrom, maelstrom-pytest, maelstrom-to-test, etc.). maelstrom-run labels Jul 8, 2024
@nfachan
Copy link
Collaborator Author

nfachan commented Jul 9, 2024

We don't want to use everything, since most images don't have a working directory.

@nfachan nfachan closed this as completed in 8c3f452 Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all-clients Issues that affect all client programs: all test runners and maelstrom-run.
Projects
None yet
Development

No branches or pull requests

1 participant