Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job spec option for making / be a bind mount. #343

Open
nfachan opened this issue Jul 17, 2024 · 0 comments
Open

Add job spec option for making / be a bind mount. #343

nfachan opened this issue Jul 17, 2024 · 0 comments
Labels
enhancement New feature or request job worker

Comments

@nfachan
Copy link
Collaborator

nfachan commented Jul 17, 2024

As it currently stands, if you provide a bind mount in the mounts vector with a mount_point of /, things don't go as expected. The problem is that the child process is already sitting on /, so it doesn't see the bind mount. There doesn't seem to be a good way to get it to re-trace the lookup path, since we've already pivot_rooted.

To solve this, we should modify the JobSpec. I'm thinking we can have two types of root. The first is "layers", and the second is "bind". You shouldn't be able to specify both "layers" and "bind" for the root.

We're going to have to do some work to allow the (local) worker to run without a fuse layer fs.

In the meantime, users can piece together bind mounts that cover most of / by individually bind mounting in all of the relevant directories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request job worker
Projects
None yet
Development

No branches or pull requests

1 participant