Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call callback immediately if stream is already closed. #28

Open
xloem opened this issue Apr 1, 2020 · 1 comment
Open

Call callback immediately if stream is already closed. #28

xloem opened this issue Apr 1, 2020 · 1 comment

Comments

@xloem
Copy link

xloem commented Apr 1, 2020

I'm reviewing this package briefly, and it looks to me like it will hang forever if a closed stream is passed to it, which could happen in a race condition.
@xloem xloem mentioned this issue Apr 1, 2020
Closed
@perry-mitchell
Copy link

Can confirm. Passing this an already ended stream means that the callback never fires.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

quick fix for already-ended streams xloem/end-of-stream
2 participants
@xloem @perry-mitchell