[Release candidate] v10 prerelease #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.js
Outdated
| * Initialize the db without metadata and load the content feed key from the header. | ||
| */ | ||
| if (this._db) { | ||
| if (!this.contentFeed || !this.metadataFeed) return cb(new Error('Must provide a db and both content/metadata feeds')) |
There was a problem hiding this comment.
This error will be hard to debug, that problem is in the constructor (where the db is passed), the error should be thrown there.
lib/keys.js
Outdated
|
|
||
| function contentKeyPair (secretKey) { | ||
| var seed = Buffer.allocUnsafe(sodium.crypto_sign_SEEDBYTES) | ||
| var context = Buffer.from('hyperdri', 'utf8') // 8 byte context |
There was a problem hiding this comment.
The context never changes, why not put it in a constant?
lib/stat.js
Outdated
| this.offset = (data && data.offset) || 0 | ||
| this.byteOffset = (data && data.byteOffset) || 0 | ||
| this.blocks = (data && data.blocks) || 0 | ||
| this.atime = data && data.atime ? getTime(data.atime) : 0 // we just set this to mtime ... |
There was a problem hiding this comment.
I know that comment was there before, but that comment makes little sense to me.
| this._openFiles[fd - 20] = null | ||
| cursor.close(cb) | ||
| } | ||
| exists (name, opts, cb) { |
There was a problem hiding this comment.
Its deprecated in node.js; should it stay implemented?
|
@mafintosh are you planning to release a blog post when v10 is released? Even if it's short, this seems like it might be a good opportunity to do a bit of marketing, and helping others catch up on what's changed. |
|
Rebased into master 💥 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@andrewosh and I (but mostly @andrewosh) have been busy getting Hyperdrive v10 ready to ship. It's a major change that moves the internal filesystem structure to hypertrie, for massive perf boosts.
The is the first "official" step towards multiwriter as the trie enables the data structures needed for that, but v10 will still be a single writer only hyperdrive, focused on getting the trie out so we can get some milage on that.
Also massively increases test coverage.
NOTE: we are still finishing up the last parts of the API
Prerelease Checklist
liveflag)