-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
End method is missing #3
Comments
The |
Right, and yes, in the following example the 'flush' event is never fired in sendFin:
|
|
Do you mean that |
The module is calling a .end method that does not exist.
Suggested modification:
Connection.prototype.end = function() {
this.emit('end' or 'close');
};
I don't know the rationale of the check of 'tick' for the 'end' event but if you call destroy for a connection that never happened (ie calling party not responding), this does not work, probably there should be a timeout for this case, please look at https://github.com/Ayms/torrent-live/blob/master/freerider.js (seek for 'utp') and maybe the 'close' event should be let to the user and the internal 'close' event should be a '_close' event or something like this --> this.once('_close', function() {... this.emit('close',xx)...}
@mafintosh I put it in my PR todo list if you want.
The text was updated successfully, but these errors were encountered: