Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On system upgrade Newly Delivered MSI modules Should Not be Disabled IF the System already uses MSI #1689

Closed
maghamed opened this issue Sep 25, 2018 · 2 comments
Assignees
Milestone

Comments

@maghamed
Copy link
Contributor

Question, after updating to the 2.3.0-beta2 metapackages I can see that a lot of modules automatically kept themselves enabled:

- Updating magento/module-inventory-bundle-product (1.0.0-beta => 1.0.0-beta2): Downloading (100%)
  ...Module Magento_InventoryBundleProduct recognized as part of Magento Multi Source Inventory implementation
  ...Keep Magento_InventoryBundleProduct module enabled as in current configuration

However this was added to my config.php:

        'Magento_InventorySourceDeductionApi' => 0,
        'Magento_InventoryGroupedProductIndexer' => 0,
        'Magento_InventoryGroupedProductAdminUi' => 0,
        'Magento_InventoryBundleProductAdminUi' => 0

These are new MSI modules that I should enable, right?


Hi @hans, did I understand correct that you had Magento 2.3.0-alpha + MSI 1.0.0-beta1 and then you have upgraded both Magento and MSI as a result some modules (actually those which were added in the scope of MLS2) are disabled.

if so, this could be a bug of upgrade - which we will discover in coming time, as for beta release we did not test upgrade from alpha -> beta

but for now you can manually enable these modules.

Thanks for letting us know!


Hans [8 minutes ago]
Yes I believe so, I’ll look up the exact installed versions I had, one sec

Hans [3 minutes ago]
Upgraded from magento/product-enterprise-edition-2.3.0-alpha72 to 2.3.0-beta2
And from magento/inventory-composer-metapackage-1.0.0-beta to 1.0.0-beta2


I think the main reason is the way how we going to seamlessly install MSI.
To prevent any backward incompatibilities and get rid of the situation when merchant is afraid to upgrade on 2.3.0 because of MSI (for example he has some Inventory customization in place).

on upgrade 2.* -> 2.3.* we install all MSI modules but make them disabled by default.

for fresh installations 2.3+ MSI is always enabled.

What happened here - you had a system upgrade, and mentioned 4 modules were added in the scope of MLS2. But at the time of upgrade system considered that these modules should be disabled even so, that there are already bunch of MSI modules which are enabled now

@maghamed
Copy link
Contributor Author

#1996

@maghamed
Copy link
Contributor Author

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants