MSI source Import #116

larsroettig · 2017-10-03T11:24:08Z

Description

Import module for Multi Source Inventory

Manual testing scenarios

Create a CSV file with e.g. following content

"source","sku","qty","status"
1,"test",60,1
2,"test",2,0
3,"test",34,1
1,"foobar",55,1
2,"foobar",44,1

Go to System > Import page in Magento backend
Choose Entity Type Stock Sources and import the CSV with append behavior

TODOs

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

WIP: MSI source import/export

- Add Documentation - phpcs fixes - Impelement phpunit test for ValidatorChain

…export

- Add SPI for Delete Multiple - Improve Delte Comand - Implement SPI

- Bugfix for Intigrationstest to new source_ids - Impelment new test case for delete behavior

- Refactoring: Add Helperfunction for convert - Impelment Replace Comand - Impelment Replace Comand Test TODO: - Implement clenup for Replace Comand

- phpcs fixes - phpmd fixes

maghamed · 2017-10-18T15:24:09Z

app/code/Magento/Inventory/Model/ResourceModel/SourceItem/DeleteMultiple.php

+ * Implementation of SourceItem delete multiple operation for specific db layer
+ * Delete Multiple used here for performance efficient purposes over single delete operation
+ */
+class DeleteMultiple


Looks like we need to remove
SourceItemRepositoryInterface::delete(SourceItemInterface $sourceItem);
method, as we have
SourceItemsDeleteInterface::execute(array $sourceItems);

which do the same

Hi @maghamed if we remove we will break the current delete function
behaviour. Because the current Delete Multiple removes all entries from the Database by only matching SKU.

If you mean it is okay I open for this an extra PR:
#140

maghamed · 2017-10-18T15:45:39Z

app/code/Magento/Inventory/Model/ResourceModel/SourceItem/DeleteMultiple.php

+     * @param SourceItemInterface[] $sourceItems
+     * @return int[]
+     */
+    private function getSourceIds($sourceItems): array


name of the method is not correct, as it returns source_id and sku list assigned to it

maghamed · 2017-10-19T07:02:13Z

app/code/Magento/Inventory/Model/SourceItem/Command/SourceItemsDelete.php

+    {
+        if (empty($sourceItems)) {
+            throw new InputException(__('Input data is empty'));
+        }


not sure that we need to throw an exception when someone tries to delete empty array of source Items.

For example, you have a replace strategy and you want to delete existing SourceItems and substitute with new ones, but on clean Magento installation with empty DB - delete would have an empty set

maghamed · 2017-10-19T07:03:47Z

...ode/Magento/Inventory/Test/Integration/Model/ResourceModel/SourceItem/DeleteMultipleTest.php

+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\Inventory\Model\ResourceModel\SourceItem;


all the tests should be stored under the namespace

Magento\Inventory\Test\Unit|Integration\Model

not mixed with code. Such tests would not be even run by Travis

maghamed · 2017-10-19T07:07:03Z

app/code/Magento/InventoryApi/Api/SourceItemsDeleteInterface.php

+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\InventoryApi\Api;


don't forget to use strict typing for newly created code

maghamed · 2017-10-19T07:25:36Z

app/code/Magento/InventoryImportExport/Model/Import/Serializer/LegacyJsonHelperInterface.php

+ *
+ * @api
+ */
+interface LegacyJsonHelperInterface


why do we need to introduce this interface? especially if it's already legacy?

If you want to make Backward Compatible change, legacy class
Magento\Framework\Json\Helper\Data should be adapted as well.

Because currently, you are breaking the contract, as AbstractEntity accept
\Magento\Framework\Json\Helper\Data $jsonHelper,
But you pass
SerializerInterface $jsonHelper, instead

maghamed · 2017-10-19T07:34:40Z

app/code/Magento/InventoryImportExport/Model/Import/Serializer/Json.php

+     */
+    public function jsonEncode($valueToEncode)
+    {
+        return $this->serializer->serialize($valueToEncode);


this method should be implemented proxying call to
$this->serialize($valueToEncode)

maghamed · 2017-10-19T07:35:47Z

app/code/Magento/InventoryImportExport/Model/Import/Serializer/Json.php

+     */
+    public function jsonDecode($encodedValue)
+    {
+        return $this->serializer->unserialize($encodedValue);


this method should be implemented proxying call to
$this->unserialize($valueToEncode)

to make all Pluginization of SerializerInterface work correctly

maghamed · 2017-10-19T07:37:39Z

app/code/Magento/InventoryImportExport/Model/Import/Validator/SkuValidator.php

+/**
+ * Extension point for row validation
+ *
+ * @api


why do we have @api on class implementation?

maghamed · 2017-10-19T07:38:00Z

app/code/Magento/InventoryImportExport/Model/Import/Validator/SourceValidator.php

+/**
+ * Extension point for source validation
+ *
+ * @api


no need to use @api here

- declare strict_types fot Import/Export Module - Add Replace Comand - Improve Coverrage - phpmd und phpcs

- declare strict_types fot Import/Export Module - phpmd and phpunit fix - review fixes

…2 into msi-source-export

…o msi-source-export

… model

Msi source export

MC-41874: Out of Stock Product is back in stock after shipping an order

vadimjustus and others added 3 commits September 29, 2017 14:44

MSI: Initial implementation of Magento_InventoryImportExport module

f1c834c

MSI: Implement append bahaviour import for source items

eca76b5

Merge pull request #115 from vadimjustus/msi-source-import-export

0e48a30

WIP: MSI source import/export

maghamed added Award: complex Inventory Import/Export labels Oct 3, 2017

maghamed mentioned this pull request Oct 3, 2017

WIP: MSI source import/export #115

Merged

12 tasks

larsroettig assigned larsroettig and vadimjustus Oct 3, 2017

larsroettig requested a review from maghamed October 3, 2017 11:33

larsroettig added this to the MSI Part I milestone Oct 3, 2017

[task] #115 Refactoring

8dcbe34

- Add Documentation - phpcs fixes - Impelement phpunit test for ValidatorChain

maghamed added the Award: special achievement label Oct 3, 2017

vadimjustus and others added 8 commits October 3, 2017 20:23

MSI: Change method accessability to private

24f776e

MSI: Implement intergration test for import entity

058d08c

wip

6b6153c

Merge remote-tracking branch 'origin/develop' into msi-source-import-…

b11c9e8

…export

wip

7d9eba5

MSI source: Impelment DelteMultiple Model and Tests

9a7067f

Remove not required fixture from methodes

7787760

MSI source: Bugfix for Indexer Integration test

3ffc60c

naydav added the WIP label Oct 11, 2017

larsroettig added 6 commits October 13, 2017 17:31

Merge remote-tracking branch 'origin/develop' into msi-source-import-…

338688b

…export

MSI source:

60064e3

- Add SPI for Delete Multiple - Improve Delte Comand - Implement SPI

MSI source:

2a30f19

- Bugfix for Intigrationstest to new source_ids - Impelment new test case for delete behavior

MSI source:

98b61ff

- Refactoring: Add Helperfunction for convert - Impelment Replace Comand - Impelment Replace Comand Test TODO: - Implement clenup for Replace Comand

phpmd and phpcs fixes

b68917a

MSI: Add Testcase for testImportDataWithWrongBehavior

457fc27

- phpcs fixes - phpmd fixes

maghamed suggested changes Oct 19, 2017

View reviewed changes

larsroettig added 2 commits October 20, 2017 19:42

MSI:

705e7f9

- declare strict_types fot Import/Export Module - Add Replace Comand - Improve Coverrage - phpmd und phpcs

MSI:

7c83028

- declare strict_types fot Import/Export Module - phpmd and phpunit fix - review fixes

larsroettig changed the title ~~WIP: MSI source import/export~~ MSI source Import Oct 26, 2017

larsroettig removed the WIP label Oct 26, 2017

larsroettig and others added 21 commits October 26, 2017 14:21

wip

2ba6943

Merge branch 'msi-source-export' of github.com:magento-engcom/magento…

c15424a

…2 into msi-source-export

WIP bugfix for export filter

c59cde0

wip

e472b69

MIS: Implement filtering for export functionality

505f630

add filter type

7158415

Merge branch 'msi-source-export' of github.com:magento-engcom/msi int…

36ac202

…o msi-source-export

MSI: Extend filtering logic for stock_source export

bc2709c

MSI: remove useless code

f132680

MSI: Refactore filtering logic in order to reduce complexity

c063161

MSI: Fix intergration tests

03018f8

MSI: Implement integration tests for stock_source export entity

d7a7256

MSI: Refactore getAttributeCollection method for stock_sources export…

7173a71

… model

MSI: Refactore filtering logic for stock_source export entity

56317f4

MSI: Static improvements

de65ba5

MSI: Refactore stock_source export entity dependencies

fe30b3d

MSI: Fix static code style issues

c16378f

MSI: Move SPI interfaces for export to model directory

18ad378

MSI: remove useless datetime filter processor

d41337a

MSI Import/Export: added comments for SPI interfaces

d70bb8f

Merge pull request #147 from magento-engcom/msi-source-export

709ec81

Msi source export

maghamed approved these changes Oct 29, 2017

View reviewed changes

maghamed merged commit 307de4f into develop Oct 29, 2017

This was referenced Oct 29, 2017

Implement Inventory Import functionality #160

Closed

Implement Export Inventory functionality #161

Closed

vkublytskyi added the Award: test coverage label Dec 14, 2017

maghamed deleted the msi-source-import-export branch December 11, 2018 18:13

magento-cicd2 pushed a commit that referenced this pull request May 12, 2021

Merge pull request #116 from magento-tsg-csl3/MC-41874

f852c8e

MC-41874: Out of Stock Product is back in stock after shipping an order

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MSI source Import #116

MSI source Import #116

larsroettig commented Oct 3, 2017 •

edited

Loading

maghamed Oct 18, 2017

larsroettig Oct 22, 2017 •

edited

Loading

maghamed Oct 18, 2017

maghamed Oct 19, 2017

maghamed Oct 19, 2017

maghamed Oct 19, 2017

maghamed Oct 19, 2017

maghamed Oct 19, 2017

maghamed Oct 19, 2017

maghamed Oct 19, 2017

maghamed Oct 19, 2017

MSI source Import #116

MSI source Import #116

Conversation

larsroettig commented Oct 3, 2017 • edited Loading

Description

Manual testing scenarios

TODOs

Contribution checklist

Choose a reason for hiding this comment

larsroettig Oct 22, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

larsroettig commented Oct 3, 2017 •

edited

Loading

larsroettig Oct 22, 2017 •

edited

Loading