Add Source Delivery awareness to Order page #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsroettig
suggested changes
Dec 15, 2017
| * Sources tab | ||
| * | ||
| * @api | ||
| * @since 100.0.2 |
There was a problem hiding this comment.
why @since
and @api pls remove and more meaningful description
| $itemSku = $orderItem->getSku(); | ||
| $orderItemId = $orderItem->getItemId(); | ||
| $sources = $this->getSourcesBySku($itemSku); | ||
|
|
| * @param string $sku | ||
| * @return array | ||
| */ | ||
| private function getSourcesBySku(string $sku) |
There was a problem hiding this comment.
pls change to getSourcesBySku(string $sku):array
| <body> | ||
| <referenceBlock name="sales_order_tabs"> | ||
| <block class="Magento\InventorySales\Block\Adminhtml\Order\View\Tab\Sources" name="sales_order_sources.grid.container"> | ||
|
|
There was a problem hiding this comment.
Replace:
<block class="Magento\InventorySales\Block\Adminhtml\Order\View\Tab\Sources" name="sales_order_sources.grid.container">
</block>
with:
<block class="Magento\InventorySales\Block\Adminhtml\Order\View\Tab\Sources" name="sales_order_sources.grid.container"/>
larsroettig
suggested changes
Dec 15, 2017
| } | ||
|
|
||
| /** | ||
| * {@inheritdoc} |
| } | ||
|
|
||
| /** | ||
| * {@inheritdoc} |
| } | ||
|
|
||
| /** | ||
| * {@inheritdoc} |
| } | ||
|
|
||
| /** | ||
| * {@inheritdoc} |
larsroettig
reviewed
Dec 15, 2017
| @@ -0,0 +1,152 @@ | |||
| <?php | |||
| /** | |||
There was a problem hiding this comment.
pls add also strict type declare(strict_types=1);
…//github.com/magento-engcom/msi into 309-add-source-to-order-page
…order-page # Conflicts: # app/code/Magento/InventoryApi/Test/Api/StockRepository/DeleteTest.php
naydav
approved these changes
Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.