-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Add to Home and web app manifest (PWA) #372
Comments
I'm trying to add the icon images in the same manner that the # Upward yaml
...
- matches: request.url.pathname
pattern: '^/homescreen144.png'
use: homescreen
...
homescreen:
inline:
status: 200
headers:
inline:
content-type:
inline: image/png
body:
file:
inline: ./media/icons/homescreen144.png
encoding: binary The response headers:
Request headers:
Navigating directly to the URL results in this page: My guess is that it has something to do with this line:
But I'm not sure. @zetlen have any ideas? Edit: Created a separate issue #408 |
Update: currently seeing a few checks in Lighthouse today for upward.bargreen.io that are worth double checking -- should be a few quick fixes to icon/image and ID of the theme color (above) which can be #ffffff for now. Thanks! Installable |
This issue is for the following packages:
[X]
venia-concept
[ ]
pwa-buildpack
[X]
peregrine
[ ]
pwa-module
[ ]
pwa-devdocs
Description
As a shopper, I want the ability to quickly add Venia to my desktop (prompted) and see a custompreview search results to help me browse products on the Venia storefront using basic keywords (e.g. hoodie) so that I can make an informed purchase.
This will quickly improve Lighthouse scores when we merge existing work here.
Additional documentation here: https://developers.google.com/web/fundamentals/web-app-manifest/
Assumptions
Tasks
The text was updated successfully, but these errors were encountered: