Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing documentation #453

Merged
merged 3 commits into from
Nov 12, 2018
Merged

Conversation

jcalcaben
Copy link
Contributor

This PR is a:

[ ] New feature
[ ] Enhancement/Optimization
[ ] Refactor
[ ] Bugfix
[ ] Test for existing code
[X] Documentation

Summary

When this pull request is merged, it will create documentation that explains how routing works in PWA Studio.

Additional information

This PR closes #320

@jcalcaben jcalcaben self-assigned this Nov 5, 2018
@jcalcaben jcalcaben requested a review from jimbo November 5, 2018 21:13
@vercel
Copy link

vercel bot commented Nov 5, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@coveralls
Copy link

coveralls commented Nov 5, 2018

Coverage Status

Coverage remained the same at 15.578% when pulling c991211 on jimothy/gh-320_routing-documentation into c261b60 on release/2.0.

@jcalcaben jcalcaben requested a review from shakyShane November 5, 2018 21:58
Copy link
Contributor

@jimbo jimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcalcaben Nice work! Great summary of a complex topic.

@jimbo jimbo merged commit f46458e into release/2.0 Nov 12, 2018
@jcalcaben jcalcaben deleted the jimothy/gh-320_routing-documentation branch July 25, 2019 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants