Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] update venia directory structure topic #487

Merged
merged 10 commits into from
Nov 26, 2018

Conversation

jcalcaben
Copy link
Contributor

This PR is a:

[ ] New feature
[ ] Enhancement/Optimization
[ ] Refactor
[ ] Bugfix
[ ] Test for existing code
[x] Documentation

Summary

When this pull request is merged, it will update the venia directory structure topic to more accurately reflect the current state of the project. It also changes the name of the topic to "Venia project structure".

Additional information

This PR closes #435

@jcalcaben jcalcaben self-assigned this Nov 9, 2018
@jcalcaben jcalcaben requested review from zetlen and jimbo November 9, 2018 19:21
@vercel
Copy link

vercel bot commented Nov 9, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@coveralls
Copy link

coveralls commented Nov 9, 2018

Coverage Status

Coverage remained the same at 17.801% when pulling 727ff10 on jimothy/gh-435_update-venia-dir-structure into 62305e5 on release/2.0.

zetlen
zetlen previously requested changes Nov 9, 2018
Copy link
Contributor

@zetlen zetlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great--just a couple of suggested changed.

zetlen and others added 2 commits November 12, 2018 11:36
Co-Authored-By: jcalcaben <jcalcaben@users.noreply.github.com>
Co-Authored-By: jcalcaben <jcalcaben@users.noreply.github.com>
@jcalcaben jcalcaben requested a review from zetlen November 12, 2018 17:37
jcalcaben and others added 2 commits November 14, 2018 09:52
- to reflect PWA Studio 2.0 Venia changes from
  Magento theme to separate storefront
This file describes the server behavior for the middle tier service between the PWA and Magento.

[`webpack.config.js`][]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this matters but line 38 is blank here. All the other entries in this section immediately follow on the next line.

@jcalcaben jcalcaben merged commit b24eaca into release/2.0 Nov 26, 2018
@jcalcaben jcalcaben deleted the jimothy/gh-435_update-venia-dir-structure branch November 26, 2018 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants