Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] theme vs storefront #509

Merged
merged 4 commits into from
Nov 16, 2018

Conversation

jcalcaben
Copy link
Contributor

@jcalcaben jcalcaben commented Nov 15, 2018

This PR is a:

[ ] New feature
[ ] Enhancement/Optimization
[ ] Refactor
[ ] Bugfix
[ ] Test for existing code
[X] Documentation

Summary

When this pull request is merged, it will create a topic that explains the difference between a Magento theme and a PWA storefront application.

Additional information

This PR closes #438 and closes #24

@vercel
Copy link

vercel bot commented Nov 15, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@jcalcaben jcalcaben requested a review from awilcoxa November 15, 2018 20:46
@coveralls
Copy link

coveralls commented Nov 15, 2018

Coverage Status

Coverage remained the same at 15.578% when pulling 4bc27d7 on jimothy/gh-439_theme-vs-storefront into 6a8fe53 on release/2.0.

Copy link

@awilcoxa awilcoxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@jcalcaben jcalcaben merged commit 6a124d4 into release/2.0 Nov 16, 2018
@jcalcaben jcalcaben deleted the jimothy/gh-439_theme-vs-storefront branch November 16, 2018 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants