Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Checkout implementation doc #673

Merged

Conversation

jcalcaben
Copy link
Contributor

This PR is a:

  • New feature
  • Enhancement/Optimization
  • Refactor
  • Bugfix
  • Test for existing code
  • Documentation

Summary

When this pull request is merged, it will rename the checkout implementation doc and update the content to add recent developments in shipping and payment methods.

Additional information

This PR closes #244 and #245

@vercel
Copy link

vercel bot commented Dec 17, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@coveralls
Copy link

coveralls commented Dec 17, 2018

Coverage Status

Coverage remained the same at 58.265% when pulling dd2f8d9 on jimothy/gh-244_document-shipping-methods-implementation into 69dc571 on release/2.0.

Copy link
Contributor

@sirugh sirugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked this PR out and ran the docs locally to verify formatting. After reading through the doc I can say that I'm good with these changes! In general as someone who doesn't know much yet about the Magento/PWA workflow this doc seems clear enough and links to code for further reading which is nice.

👍

@jcalcaben jcalcaben merged commit 2619630 into release/2.0 Jan 4, 2019
@jcalcaben jcalcaben deleted the jimothy/gh-244_document-shipping-methods-implementation branch January 4, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants