Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracting keywords from Exif segment #1759

Closed
Nazar65 opened this issue Aug 17, 2020 · 3 comments
Closed

Extracting keywords from Exif segment #1759

Nazar65 opened this issue Aug 17, 2020 · 3 comments
Assignees
Labels
Backend Complex Priority: P3 May be fixed according to the position in the backlog Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround
Milestone

Comments

@Nazar65
Copy link
Member

Nazar65 commented Aug 17, 2020

Description (*)

after magento/magento2#29576 will be merged

There is two fields where keywords can be extracted:
1. Exif.Photo.UserComment
2. Exif.Image.XPKeywords

the second one per documentation is related only for WINDOWS XP guys, but there is no standard filed for keywords

Need to decide wich field we will using for extracting Keywords from Exif data, but as per description to 'Exif.Photo.UserComment'

A tag for Exif users to write keywords or comments on the image besides those in <ImageDescription>, and without the character code limitations of the <ImageDescription> tag.

i would prefer to use this file.

reference to official documentation https://exiv2.org/tags.html

After the field will be chosen, need to modify readers to extract keywords

  1. app/code/Magento/MediaGalleryMetadata/Model/Jpeg/Segment/ReadExif.php
  2. app/code/Magento/MediaGalleryMetadata/Model/Png/Segment/ReadExif.php
@m2-assistant
Copy link

m2-assistant bot commented Aug 17, 2020

Hi @Nazar65. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@sivaschenko sivaschenko added Priority: P3 May be fixed according to the position in the backlog Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround Backend Complex labels Aug 18, 2020
@konarshankar07
Copy link
Contributor

@magento I'm working on this

@sivaschenko
Copy link
Member

@konarshankar07 do you have any updates for this issue? I think this issue can be closed based on the discussion on the public meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Complex Priority: P3 May be fixed according to the position in the backlog Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround
Projects
None yet
Development

No branches or pull requests

3 participants