Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration propagation #427

Closed
magento-engcom-team opened this issue Nov 11, 2020 · 9 comments · Fixed by magento/commerce-data-export#15 or magento/storefront-message-broker#4
Closed
Assignees
Milestone

Comments

@magento-engcom-team
Copy link

magento-engcom-team commented Nov 11, 2020

Store configuration settings which can modify Storefront should be propagated to Storefront

AC:

  • Create a new event which will send a message with Configuration data to Message Broker from Export API
    • collected configuration paths should be described in di.xml
    • only send a message if the value was changed
    • the initial command should collect and send all described configuration data
  • Consumers(s) on the Message Broker side save the configuration to the corresponding Service via gRPC
    • configuration in di.xml can be used to determine what configuration should be imported to specified service

Proposed service & message structure:

service Catalog { # will be similar for any service 
  rpc importConfig (ImportConfigRequest) returns (ImportConfigResponse)  {}
}

message ImportConfigRequest {
  repeated Config config = 1;
}

message ImportConfigResponse {
  bool status = 1;
  string message = 2;
}

message Config {
  string name = 1;
  string value = 2;
}
@magento-engcom-team
Copy link
Author

The issue was exported from the internal JIRA. The link to the original JIRA issue: https://jira.corp.magento.com/browse/SFAPP-134

@m2-assistant
Copy link

m2-assistant bot commented Nov 11, 2020

Hi @magento-engcom-team. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@nrkapoor nrkapoor added this to the EAP milestone Nov 11, 2020
@mslabko
Copy link
Member

mslabko commented Nov 12, 2020

E.g. we can have next flow:

Admin (Magento)
1. changed system configuration: system/path/searh/price_algo :: auto
2. send message to Message Bus ({name:system/path/searh/price_algo, value:auto}, ...], 
3. in MessageBroker: resolveServiceDestinationAndMapConfigName(messageFromMessageBus)
3.1.  resolved service according to config: "search", config name: "price_algo"
3.2. $service = new SearchGRPCService->ImportConfig([{name: price_algo, value: auto}])

@owlsmage
Copy link
Contributor

@magento I am working on this

@m2-assistant
Copy link

m2-assistant bot commented Nov 12, 2020

Hi @owlsmage! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@owlsmage
Copy link
Contributor

@magento add to contributors team

@m2-assistant
Copy link

m2-assistant bot commented Nov 12, 2020

Hi @owlsmage! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@owlsmage
Copy link
Contributor

@magento I am working on this

@owlsmage
Copy link
Contributor

@mslabko PR for Magento module to export configuration changes magento/commerce-data-export#15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment