[Search] Propagate search-specific configuration to Search service

[magento-engcom-team]

Need to propagate search-specific configuration to Search service

AC:

• Add new "ImportConfig" method to Search Service
• Add search-specific configuration in message-broker
• Use imported configuration inside Search service instead of hard-coded config values
  • \Magento\SearchStorefrontStub\Model\Search\Options and other places

Proto schema:

service Search {
  rpc ImportConfig (ImportConfigRequest) returns (ImportConfigResponse)  {}
}

message GetConfigRequest {
  repeated string name = 1;
}

message ImportConfigRequest {
  repeated Config config = 1;
}

message ImportConfigResponse {
  bool status = 1;
  string message = 2;
}

message Config {
  string name = 1;
  string value = 2;
}

 

[magento-engcom-team]

The issue was exported from the internal JIRA. The link to the original JIRA issue: https://jira.corp.magento.com/browse/SFAPP-175

[m2-assistant]

Hi @magento-engcom-team. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[lykhachov]

required config paths are:
'catalog/layered_navigation/price_range_calculation'
'catalog/layered_navigation/interval_division_limit'
'catalog/layered_navigation/price_range_step'
'catalog/layered_navigation/price_range_max_intervals'
'catalog/layered_navigation/one_price_interval'

desired config are:
Magento Elasticsearch connection config

[RuslanKostiv1]

@lykhachov @mslabko
Should store node be in message Config for search service?
It's present in proto scheme here

        message Config {
          string name = 1;
          string value = 2;
          string store = 3;
        }

[nihara47]

@magento I am working on this

[lykhachov]

I suppose yes, as we have store node in the search request

[nihara47]

@RuslanKostiv1 I have provided a PR for addition of new "importconfig" method for search service
magento/storefront-search-ce#7
Please suggest if any changes on that, Thank you
@lykhachov

[nihara47]

required config paths are:
'catalog/layered_navigation/price_range_calculation'
'catalog/layered_navigation/interval_division_limit'
'catalog/layered_navigation/price_range_step'
'catalog/layered_navigation/price_range_max_intervals'
'catalog/layered_navigation/one_price_interval'

desired config are:
Magento Elasticsearch connection config

@lykhachov @RuslanKostiv1 Can you provide me some insights as where I will add these config paths
As I understand we need to declare and map those inside etc/configuration_import_mapping.xml but in which module to use these imported configuration inside Search services

[mslabko]

Hey @nihara47 , thank you for your contribution! I will try to check your PR next week