Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return rating title in ProductReviews service #464

Open
magento-engcom-team opened this issue Dec 10, 2020 · 4 comments
Open

Return rating title in ProductReviews service #464

magento-engcom-team opened this issue Dec 10, 2020 · 4 comments
Assignees

Comments

@magento-engcom-team
Copy link

magento-engcom-team commented Dec 10, 2020

In the current implementation, we return rating_id and rating_value. 

It's necessary to return the rating title as well to be used on the storefront. 

repo: https://github.com/magento/storefront-product-reviews-ce/

Extend Rating message with "name" value and use in \Magento\ReviewsStorefront\Model\ProductReviewsServer::getProductReviews method

message Rating {
  string rating_id = 1;
  string value = 2; 
  string name = 3; // new field
}

 

@magento-engcom-team
Copy link
Author

The issue was exported from the internal JIRA. The link to the original JIRA issue: https://jira.corp.magento.com/browse/SFAPP-181

@m2-assistant
Copy link

m2-assistant bot commented Dec 10, 2020

Hi @magento-engcom-team. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@RakeshJesadiya
Copy link

@magento I am working on this.

@RakeshJesadiya
Copy link

I am facing issue on the Grpc UI for the review storefront.
Request payload is Product Id 1 and store code is default,
request-review

Output has an error,
response

Is this known bug to storefront review repo?

FYI @kandy @mslabko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants