-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Price Book scope validation #472
Labels
Comments
Hi @lykhachov. Thank you for your report. Please, add a comment to assign the issue:
|
mslabko
changed the title
Check JSON approach in storing scope data for Price Books
Improve Price Book scope validation
Dec 16, 2020
@magento export issue to Jira project SFAPP as Task |
✅ Jira issue (https://jira.corp.magento.com/browse/SFAPP-190) is successfully created for this issue. |
github-jira-sync-bot
added
Progress: ready for grooming
and removed
Progress: ready for dev
labels
Feb 11, 2021
github-jira-sync-bot
added
Progress: backlog
and removed
Progress: ready for grooming
labels
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current approach can lead to performance problems during PR creation with big amoun of price books
Method: \Magento\PricingStorefront\Model\PriceBookRepository::validatePriceBookUnique.
Investigate options to improve this.
For example, we can utilize "JSON" type for and replace existing website/customer_group columns with new column "scopes" with the following structure:
{"w": [...], "cg": [...]}
, index for both fields should be createdThe text was updated successfully, but these errors were encountered: