Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Price Book scope validation #472

Open
lykhachov opened this issue Dec 16, 2020 · 3 comments
Open

Improve Price Book scope validation #472

lykhachov opened this issue Dec 16, 2020 · 3 comments

Comments

@lykhachov
Copy link
Contributor

lykhachov commented Dec 16, 2020

Current approach can lead to performance problems during PR creation with big amoun of price books

Method: \Magento\PricingStorefront\Model\PriceBookRepository::validatePriceBookUnique.

Investigate options to improve this.
For example, we can utilize "JSON" type for and replace existing website/customer_group columns with new column "scopes" with the following structure: {"w": [...], "cg": [...]}, index for both fields should be created

@m2-assistant
Copy link

m2-assistant bot commented Dec 16, 2020

Hi @lykhachov. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@mslabko mslabko changed the title Check JSON approach in storing scope data for Price Books Improve Price Book scope validation Dec 16, 2020
@mslabko
Copy link
Member

mslabko commented Dec 16, 2020

@magento export issue to Jira project SFAPP as Task

@magento-engcom-team
Copy link

✅ Jira issue (https://jira.corp.magento.com/browse/SFAPP-190) is successfully created for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants