#687 Remove Redundant 'isset'

Author: Lars Roettig

app/code/Magento/CustomerGraphQl/Model/Resolver/CreateCustomer.php

@@ -51,7 +51,7 @@ public function resolve(
         array $value = null,
         array $args = null
     ) {
-        if (!isset($args['input']) || !is_array($args['input']) || empty($args['input'])) {
+        if (empty($args['input']) || !is_array($args['input'])) {
             throw new GraphQlInputException(__('"input" value should be specified'));
         }
 

app/code/Magento/CustomerGraphQl/Model/Resolver/CreateCustomerAddress.php

@@ -60,7 +60,7 @@ public function resolve(
         array $value = null,
         array $args = null
     ) {
-        if (!isset($args['input']) || !is_array($args['input']) || empty($args['input'])) {
+        if (empty($args['input']) || !is_array($args['input'])) {
             throw new GraphQlInputException(__('"input" value should be specified'));
         }
 

app/code/Magento/CustomerGraphQl/Model/Resolver/DeleteCustomerAddress.php

@@ -60,7 +60,7 @@ public function resolve(
         array $value = null,
         array $args = null
     ) {
-        if (!isset($args['id']) || empty($args['id'])) {
+        if (empty($args['id'])) {
             throw new GraphQlInputException(__('Address "id" value should be specified'));
         }
 

app/code/Magento/CustomerGraphQl/Model/Resolver/GenerateCustomerToken.php

@@ -44,11 +44,11 @@ public function resolve(
         array $value = null,
         array $args = null
     ) {
-        if (!isset($args['email']) || empty($args['email'])) {
+        if (empty($args['email'])) {
             throw new GraphQlInputException(__('Specify the "email" value.'));
         }
 
-        if (!isset($args['password']) || empty($args['password'])) {
+        if (empty($args['password'])) {
             throw new GraphQlInputException(__('Specify the "password" value.'));
         }
 

app/code/Magento/CustomerGraphQl/Model/Resolver/IsEmailAvailable.php

@@ -52,7 +52,7 @@ public function resolve(
         array $value = null,
         array $args = null
     ) {
-        if (!isset($args['email']) || empty($args['email'])) {
+        if (empty($args['email'])) {
             throw new GraphQlInputException(__('Email must be specified'));
         }
 

app/code/Magento/CustomerGraphQl/Model/Resolver/UpdateCustomer.php

@@ -60,7 +60,7 @@ public function resolve(
         array $value = null,
         array $args = null
     ) {
-        if (!isset($args['input']) || !is_array($args['input']) || empty($args['input'])) {
+        if (empty($args['input']) || !is_array($args['input'])) {
             throw new GraphQlInputException(__('"input" value should be specified'));
         }
 

app/code/Magento/CustomerGraphQl/Model/Resolver/UpdateCustomerAddress.php

@@ -69,11 +69,11 @@ public function resolve(
         array $value = null,
         array $args = null
     ) {
-        if (!isset($args['id']) || empty($args['id'])) {
+        if (empty($args['id'])) {
             throw new GraphQlInputException(__('Address "id" value must be specified'));
         }
 
-        if (!isset($args['input']) || !is_array($args['input']) || empty($args['input'])) {
+        if (empty($args['input']) || !is_array($args['input'])) {
             throw new GraphQlInputException(__('"input" value must be specified'));
         }
 

app/code/Magento/QuoteGraphQl/Model/Resolver/AddSimpleProductsToCart.php

@@ -47,12 +47,12 @@ public function __construct(
      */
     public function resolve(Field $field, $context, ResolveInfo $info, array $value = null, array $args = null)
     {
-        if (!isset($args['input']['cart_id']) || empty($args['input']['cart_id'])) {
+        if (empty($args['input']['cart_id'])) {
             throw new GraphQlInputException(__('Required parameter "cart_id" is missing'));
         }
         $maskedCartId = $args['input']['cart_id'];
 
-        if (!isset($args['input']['cart_items']) || empty($args['input']['cart_items'])
+        if (empty($args['input']['cart_items'])
             || !is_array($args['input']['cart_items'])
         ) {
             throw new GraphQlInputException(__('Required parameter "cart_items" is missing'));

app/code/Magento/QuoteGraphQl/Model/Resolver/ApplyCouponToCart.php

@@ -50,12 +50,12 @@ public function __construct(
      */
     public function resolve(Field $field, $context, ResolveInfo $info, array $value = null, array $args = null)
     {
-        if (!isset($args['input']['cart_id']) || empty($args['input']['cart_id'])) {
+        if (empty($args['input']['cart_id'])) {
             throw new GraphQlInputException(__('Required parameter "cart_id" is missing'));
         }
         $maskedCartId = $args['input']['cart_id'];
 
-        if (!isset($args['input']['coupon_code']) || empty($args['input']['coupon_code'])) {
+        if (empty($args['input']['coupon_code'])) {
             throw new GraphQlInputException(__('Required parameter "coupon_code" is missing'));
         }
         $couponCode = $args['input']['coupon_code'];

app/code/Magento/QuoteGraphQl/Model/Resolver/Cart.php

@@ -37,7 +37,7 @@ public function __construct(
      */
     public function resolve(Field $field, $context, ResolveInfo $info, array $value = null, array $args = null)
     {
-        if (!isset($args['cart_id']) || empty($args['cart_id'])) {
+        if (empty($args['cart_id'])) {
             throw new GraphQlInputException(__('Required parameter "cart_id" is missing'));
         }
         $maskedCartId = $args['cart_id'];