Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Cleanup quote GraphQL scheme #384

Closed
naydav opened this issue Feb 21, 2019 · 1 comment
Closed

Cleanup quote GraphQL scheme #384

naydav opened this issue Feb 21, 2019 · 1 comment
Assignees
@naydav
Labels
enhancement New feature or request
Milestone
Release: 2.3.2

Comments

@naydav
Copy link
Contributor

naydav commented Feb 21, 2019

Removing of not used types

  1. Remove duplication
applyCouponToCart(input: ApplyCouponToCartInput): ApplyCouponToCartOutput @resolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\Coupon\\ApplyCouponToCart")
removeCouponFromCart(input: RemoveCouponFromCartInput): RemoveCouponFromCartOutput @resolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\Coupon\\RemoveCouponFromCart")
  1. Remove unused and wrong type
input AvailableShippingMethodsOnCartInput {
    cart_id: String!
    customer_address_id: Int
    address: CartAddressInput
}
  1. Remove unused and wrong type
input CartItemDetailsInput {
    sku: String!
    qty: Float!
}
@naydav naydav self-assigned this Feb 21, 2019
@naydav naydav changed the title Cleanup quote scheme Cleanup quote GraphQL scheme Feb 21, 2019
@naydav naydav mentioned this issue Feb 21, 2019
Merged
@naydav
Copy link
Contributor Author

naydav commented Feb 21, 2019

#385

@naydav naydav closed this as completed Feb 21, 2019
@naydav naydav added this to the Release: 2.3.2 milestone Feb 21, 2019
@TomashKhamlai TomashKhamlai added the enhancement New feature or request label Mar 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@naydav naydav

Labels
enhancement New feature or request
Projects
None yet
Milestone
Release: 2.3.2
Development

No branches or pull requests
2 participants
@naydav @TomashKhamlai