Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

[Customer] CustomerInput improvements #912

Closed
paliarush opened this issue Sep 6, 2019 · 0 comments
Closed

[Customer] CustomerInput improvements #912

paliarush opened this issue Sep 6, 2019 · 0 comments
Labels
Architects: approved Issue is checked and approved by architecture team. Component: CustomerGraphQl good first issue Good for newcomers
Milestone
Release: 2.3.4

Comments

@paliarush
Copy link
Contributor

paliarush commented Sep 6, 2019 •
edited
Loading

Acceptance criteria:

  • Mark email with ! in CustomerInput. Even though it is a breaking change from schema perspective, in reality it is not breaking because it was required by the application layer previously
  • Fix comment in gender r(. Fix identical issue in other places in the schema.
  • Fix comments of taxvat field in CustomerInput and everywhere in the schema: Tax/VAT should be replaced with Value-added tax (VAT)
@lenaorobei lenaorobei removed the good first issue Good for newcomers label Sep 16, 2019
@melnikovi melnikovi added the Architects: approved Issue is checked and approved by architecture team. label Sep 17, 2019
@VitaliyBoyko VitaliyBoyko mentioned this issue Sep 18, 2019
Merged
@VitaliyBoyko VitaliyBoyko self-assigned this Sep 18, 2019
@lenaorobei lenaorobei added the good first issue Good for newcomers label Sep 27, 2019
@lenaorobei lenaorobei added this to the Release: 2.3.4 milestone Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Architects: approved Issue is checked and approved by architecture team. Component: CustomerGraphQl good first issue Good for newcomers
Projects
None yet
Milestone
Release: 2.3.4
Development

No branches or pull requests
4 participants
@melnikovi @paliarush @lenaorobei @VitaliyBoyko