Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark Inventory interfaces and blocks as API #32067

Closed
sivaschenko opened this issue Feb 9, 2021 · 8 comments
Closed

Mark Inventory interfaces and blocks as API #32067

sivaschenko opened this issue Feb 9, 2021 · 8 comments
Assignees
@ProkopovVitaliy
Labels
Area: APIs Component: Api Use with concrete module component label E.g. "Component: Api" + "Catalog" Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: API Changes Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@sivaschenko
Copy link
Member

sivaschenko commented Feb 9, 2021 •
edited by gabrieldagama
Loading

The following interfaces and blocks should be marked as API in api-changes-develop branch

  1. inventory/InventoryApi/Model/IsProductAssignedToStockInterface.php
  2. inventory/InventoryCatalogApi/Model/SourceItemsProcessorInterface.php
  3. inventory/InventoryInStorePickupGraphQl/Model/Resolver/PickupLocations/SearchRequest/ResolverInterface.php
  4. inventory/InventoryIndexer/Indexer/SelectBuilderInterface.php
  5. inventory/InventorySalesAdminUi/Model/SalesChannelNameResolverInterface.php
  6. inventory/InventorySalesApi/Model/GetSkuFromOrderItemInterface.php
  7. inventory/InventorySalesApi/Model/ReturnProcessor/Request/ItemsToRefundInterface.php
  8. inventory/InventorySalesApi/Model/StockByWebsiteIdResolverInterface.php
  9. Magento\InventoryShippingAdminUi\Block\Adminhtml\Shipment\Inventory
  10. Magento\InventoryShippingAdminUi\Block\Adminhtml\Order\View\ShipButton
@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2021

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

@sivaschenko sivaschenko changed the title Mark interfaces as API Mark interfaces and blocks as API Feb 9, 2021
@sivaschenko sivaschenko transferred this issue from magento/inventory Feb 9, 2021
@sivaschenko sivaschenko added this to the 2.5 milestone Feb 9, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2021

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sivaschenko sivaschenko added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Project: API Changes and removed Progress: ready for dev labels Feb 9, 2021
@sivaschenko sivaschenko changed the title Mark interfaces and blocks as API Mark Inventory interfaces and blocks as API Feb 9, 2021
@ProkopovVitaliy
Copy link
Contributor

@magento i am working on this

This was referenced Feb 10, 2021
Closed
Merged
@gabrieldagama gabrieldagama removed this from the 2.5 milestone May 28, 2021
@engcom-Hotel engcom-Hotel added Component: Api Use with concrete module component label E.g. "Component: Api" + "Catalog" Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Aug 25, 2021
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-1050 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Aug 25, 2021

✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@github-jira-sync-bot
Copy link

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.magento.com/browse/AC-1050

1 similar comment
@github-jira-sync-bot
Copy link

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.magento.com/browse/AC-1050

@engcom-November
Copy link
Contributor

Hi,
This issue got fixed in the scope of the internal Jira ticket AC-1050 and has been merged to api-changes-develop  branch
Commit id: e4406290483ff6e3f34cb2932aa3ef6772cc7b8a
Based on Jira, target version is 2.4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ProkopovVitaliy ProkopovVitaliy

Labels
Area: APIs Component: Api Use with concrete module component label E.g. "Component: Api" + "Catalog" Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: API Changes Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
High Priority Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Marked Inventory interfaces and blocks as API
7 participants
@sivaschenko @gabrieldagama @ProkopovVitaliy @engcom-Echo @engcom-Hotel @engcom-November @github-jira-sync-bot