Avoid use of constant in trait

fredden · fredden · commit c11500100784 · 2023-07-03T14:19:51.000+01:00
This is to support old versions of PHP.
diff --git a/Magento2/Sniffs/Legacy/ParseXMLTrait.php b/Magento2/Sniffs/Legacy/ParseXMLTrait.php
@@ -13,8 +13,6 @@
 
 trait ParseXMLTrait
 {
-    private const ERROR_CODE_XML = 'WrongXML';
-
     /**
      * Format the incoming XML to avoid tags split into several lines.
      *
@@ -33,7 +31,7 @@ private function getFormattedXML(File $phpcsFile)
             $phpcsFile->addError(
                 "Couldn't parse contents of '%s', check that they are in valid XML format.",
                 0,
-                self::ERROR_CODE_XML,
+                'WrongXML',
                 [
                     Common::stripBasepath($phpcsFile->getFilename(), $phpcsFile->config->basepath),
                 ]

Original file line number	Diff line number	Diff line change
`@@ -13,8 +13,6 @@`
`13`	`13`
`14`	`14`	`trait ParseXMLTrait`
`15`	`15`	`{`
`16`		`- private const ERROR_CODE_XML = 'WrongXML';`
`17`		`-`
`18`	`16`	`/**`
`19`	`17`	`* Format the incoming XML to avoid tags split into several lines.`
`20`	`18`	`*`
`@@ -33,7 +31,7 @@ private function getFormattedXML(File $phpcsFile)`
`33`	`31`	`$phpcsFile->addError(`
`34`	`32`	`"Couldn't parse contents of '%s', check that they are in valid XML format.",`
`35`	`33`	`0,`
`36`		`- self::ERROR_CODE_XML,`
	`34`	`+ 'WrongXML',`
`37`	`35`	`[`
`38`	`36`	`Common::stripBasepath($phpcsFile->getFilename(), $phpcsFile->config->basepath),`
`39`	`37`	`]`