Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on how are this coding standards used in the Quality Reports of Adobe Commerce Marketplace #481

Open
madalinignisca opened this issue Jul 2, 2024 · 1 comment
Labels
enhancement Improvements to existing rules Progress: ready for grooming

Comments

@madalinignisca
Copy link

Description

This is more of a question. I found this repository through the link to a Magento extension for passed Coding Standards.

My particular concern is the filesystem. I looked over the https://github.com/magento/magento-coding-standard/tree/develop/Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php, and it made me think that it only warns about any of those functions.

Is the Magento Marketplace rejecting extensions that use direct filesystem functions, making them incompatible with remote storage? We did face this kind of extension when buying directly from vendors not listed on the Marketplace, and we'd like to know how much to trust the Marketplace for all the Quality Reports.

Expected behaviour

Any listed extension in the Marketplace with a passed Coding Standard would not have any warnings and work 100% with remote storage.

Benefits

All extensions would be remote storage compatible.

Additional information

Trust that these tests are enforced for Adobe Commerce Marketplace and don't allow warnings.

@madalinignisca madalinignisca added the enhancement Improvements to existing rules label Jul 2, 2024
Copy link

m2-assistant bot commented Jul 2, 2024

Hi @madalinignisca. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing rules Progress: ready for grooming
Projects
Status: Ready for Grooming
Development

No branches or pull requests

1 participant