Skip to content

Commit e3301a9

Browse files
bohdan-harniukbohdan-harniuk
committed
869: Enhanced error outputting for new Magento 2 Cron Group generation
1 parent f80dbf2 commit e3301a9

File tree

2 files changed

+45
-34
lines changed

2 files changed

+45
-34
lines changed

‎src/com/magento/idea/magento2plugin/actions/generation/dialog/NewCronGroupDialog.form

Lines changed: 42 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
</grid>
5050
</children>
5151
</grid>
52-
<grid id="e3588" layout-manager="GridLayoutManager" row-count="10" column-count="4" same-size-horizontally="false" same-size-vertically="false" hgap="-1" vgap="-1">
52+
<grid id="e3588" layout-manager="GridLayoutManager" row-count="11" column-count="4" same-size-horizontally="false" same-size-vertically="false" hgap="-1" vgap="-1">
5353
<margin top="0" left="0" bottom="0" right="0"/>
5454
<constraints>
5555
<grid row="0" column="0" row-span="1" col-span="1" vsize-policy="3" hsize-policy="3" anchor="0" fill="3" indent="0" use-parent-layout="false"/>
@@ -59,107 +59,107 @@
5959
<children>
6060
<component id="62d53" class="javax.swing.JLabel">
6161
<constraints>
62-
<grid row="3" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
62+
<grid row="4" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
6363
</constraints>
6464
<properties>
6565
<text value="schedule_generate_every"/>
6666
</properties>
6767
</component>
6868
<component id="49a5e" class="javax.swing.JLabel">
6969
<constraints>
70-
<grid row="7" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
70+
<grid row="8" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
7171
</constraints>
7272
<properties>
7373
<text value="history_success_lifetime"/>
7474
</properties>
7575
</component>
7676
<component id="aa5e3" class="javax.swing.JLabel">
7777
<constraints>
78-
<grid row="8" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
78+
<grid row="9" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
7979
</constraints>
8080
<properties>
8181
<text value="history_failure_lifetime"/>
8282
</properties>
8383
</component>
8484
<component id="bc766" class="javax.swing.JLabel">
8585
<constraints>
86-
<grid row="4" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
86+
<grid row="5" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
8787
</constraints>
8888
<properties>
8989
<text value="schedule_ahead_for"/>
9090
</properties>
9191
</component>
9292
<component id="725d3" class="javax.swing.JLabel">
9393
<constraints>
94-
<grid row="6" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
94+
<grid row="7" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
9595
</constraints>
9696
<properties>
9797
<text value="history_cleanup_every"/>
9898
</properties>
9999
</component>
100100
<component id="458f5" class="javax.swing.JLabel">
101101
<constraints>
102-
<grid row="5" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
102+
<grid row="6" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
103103
</constraints>
104104
<properties>
105105
<text value="schedule_lifetime"/>
106106
</properties>
107107
</component>
108108
<component id="b9c44" class="javax.swing.JSpinner" binding="scheduleAheadFor">
109109
<constraints>
110-
<grid row="4" column="1" row-span="1" col-span="1" vsize-policy="0" hsize-policy="6" anchor="8" fill="1" indent="0" use-parent-layout="false"/>
110+
<grid row="5" column="1" row-span="1" col-span="1" vsize-policy="0" hsize-policy="6" anchor="8" fill="1" indent="0" use-parent-layout="false"/>
111111
</constraints>
112112
<properties/>
113113
</component>
114114
<component id="db3dd" class="javax.swing.JSpinner" binding="scheduleGenerateEvery">
115115
<constraints>
116-
<grid row="3" column="1" row-span="1" col-span="1" vsize-policy="0" hsize-policy="6" anchor="8" fill="1" indent="0" use-parent-layout="false"/>
116+
<grid row="4" column="1" row-span="1" col-span="1" vsize-policy="0" hsize-policy="6" anchor="8" fill="1" indent="0" use-parent-layout="false"/>
117117
</constraints>
118118
<properties/>
119119
</component>
120120
<component id="a1752" class="javax.swing.JSpinner" binding="scheduleLifetime">
121121
<constraints>
122-
<grid row="5" column="1" row-span="1" col-span="1" vsize-policy="0" hsize-policy="6" anchor="8" fill="1" indent="0" use-parent-layout="false"/>
122+
<grid row="6" column="1" row-span="1" col-span="1" vsize-policy="0" hsize-policy="6" anchor="8" fill="1" indent="0" use-parent-layout="false"/>
123123
</constraints>
124124
<properties/>
125125
</component>
126126
<component id="fcf84" class="javax.swing.JSpinner" binding="historyCleanupEvery">
127127
<constraints>
128-
<grid row="6" column="1" row-span="1" col-span="1" vsize-policy="0" hsize-policy="6" anchor="8" fill="1" indent="0" use-parent-layout="false"/>
128+
<grid row="7" column="1" row-span="1" col-span="1" vsize-policy="0" hsize-policy="6" anchor="8" fill="1" indent="0" use-parent-layout="false"/>
129129
</constraints>
130130
<properties/>
131131
</component>
132132
<component id="cce0e" class="javax.swing.JSpinner" binding="historySuccessLifetime">
133133
<constraints>
134-
<grid row="7" column="1" row-span="1" col-span="1" vsize-policy="0" hsize-policy="6" anchor="8" fill="1" indent="0" use-parent-layout="false"/>
134+
<grid row="8" column="1" row-span="1" col-span="1" vsize-policy="0" hsize-policy="6" anchor="8" fill="1" indent="0" use-parent-layout="false"/>
135135
</constraints>
136136
<properties/>
137137
</component>
138138
<component id="b3820" class="javax.swing.JSpinner" binding="historyFailureLifetime">
139139
<constraints>
140-
<grid row="8" column="1" row-span="1" col-span="1" vsize-policy="0" hsize-policy="6" anchor="8" fill="1" indent="0" use-parent-layout="false"/>
140+
<grid row="9" column="1" row-span="1" col-span="1" vsize-policy="0" hsize-policy="6" anchor="8" fill="1" indent="0" use-parent-layout="false"/>
141141
</constraints>
142142
<properties/>
143143
</component>
144144
<component id="64bd4" class="javax.swing.JLabel">
145145
<constraints>
146-
<grid row="2" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
146+
<grid row="3" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
147147
</constraints>
148148
<properties>
149149
<text resource-bundle="magento2/common" key="common.optionName"/>
150150
</properties>
151151
</component>
152152
<component id="d5e85" class="javax.swing.JLabel">
153153
<constraints>
154-
<grid row="2" column="1" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
154+
<grid row="3" column="1" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
155155
</constraints>
156156
<properties>
157157
<text resource-bundle="magento2/common" key="common.optionValue"/>
158158
</properties>
159159
</component>
160160
<component id="2697c" class="javax.swing.JCheckBox" binding="addScheduleGenerateEvery">
161161
<constraints>
162-
<grid row="3" column="2" row-span="1" col-span="1" vsize-policy="0" hsize-policy="3" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
162+
<grid row="4" column="2" row-span="1" col-span="1" vsize-policy="0" hsize-policy="3" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
163163
</constraints>
164164
<properties>
165165
<selected value="true"/>
@@ -168,7 +168,7 @@
168168
</component>
169169
<component id="d3676" class="javax.swing.JCheckBox" binding="addScheduleAheadFor">
170170
<constraints>
171-
<grid row="4" column="2" row-span="1" col-span="1" vsize-policy="0" hsize-policy="3" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
171+
<grid row="5" column="2" row-span="1" col-span="1" vsize-policy="0" hsize-policy="3" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
172172
</constraints>
173173
<properties>
174174
<selected value="true"/>
@@ -177,7 +177,7 @@
177177
</component>
178178
<component id="b603b" class="javax.swing.JCheckBox" binding="addScheduleLifetime">
179179
<constraints>
180-
<grid row="5" column="2" row-span="1" col-span="1" vsize-policy="0" hsize-policy="3" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
180+
<grid row="6" column="2" row-span="1" col-span="1" vsize-policy="0" hsize-policy="3" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
181181
</constraints>
182182
<properties>
183183
<selected value="true"/>
@@ -186,7 +186,7 @@
186186
</component>
187187
<component id="cabce" class="javax.swing.JCheckBox" binding="addHistoryCleanupEvery">
188188
<constraints>
189-
<grid row="6" column="2" row-span="1" col-span="1" vsize-policy="0" hsize-policy="3" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
189+
<grid row="7" column="2" row-span="1" col-span="1" vsize-policy="0" hsize-policy="3" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
190190
</constraints>
191191
<properties>
192192
<selected value="true"/>
@@ -195,7 +195,7 @@
195195
</component>
196196
<component id="f73d8" class="javax.swing.JCheckBox" binding="addHistorySuccessLifetime">
197197
<constraints>
198-
<grid row="7" column="2" row-span="1" col-span="1" vsize-policy="0" hsize-policy="3" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
198+
<grid row="8" column="2" row-span="1" col-span="1" vsize-policy="0" hsize-policy="3" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
199199
</constraints>
200200
<properties>
201201
<selected value="true"/>
@@ -204,7 +204,7 @@
204204
</component>
205205
<component id="c537b" class="javax.swing.JCheckBox" binding="addHistoryFailureLifetime">
206206
<constraints>
207-
<grid row="8" column="2" row-span="1" col-span="1" vsize-policy="0" hsize-policy="3" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
207+
<grid row="9" column="2" row-span="1" col-span="1" vsize-policy="0" hsize-policy="3" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
208208
</constraints>
209209
<properties>
210210
<selected value="true"/>
@@ -213,15 +213,15 @@
213213
</component>
214214
<component id="2181e" class="javax.swing.JLabel">
215215
<constraints>
216-
<grid row="2" column="2" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
216+
<grid row="3" column="2" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
217217
</constraints>
218218
<properties>
219219
<text resource-bundle="magento2/common" key="common.optionAdd"/>
220220
</properties>
221221
</component>
222222
<component id="f1e69" class="javax.swing.JLabel">
223223
<constraints>
224-
<grid row="3" column="3" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
224+
<grid row="4" column="3" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
225225
</constraints>
226226
<properties>
227227
<text resource-bundle="magento2/common" key="common.cronGroup.description.scheduleGenerateEvery"/>
@@ -247,55 +247,55 @@
247247
</component>
248248
<component id="cff9e" class="javax.swing.JLabel">
249249
<constraints>
250-
<grid row="4" column="3" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
250+
<grid row="5" column="3" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
251251
</constraints>
252252
<properties>
253253
<text resource-bundle="magento2/common" key="common.cronGroup.description.scheduleAheadFor"/>
254254
</properties>
255255
</component>
256256
<component id="86513" class="javax.swing.JLabel">
257257
<constraints>
258-
<grid row="5" column="3" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
258+
<grid row="6" column="3" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
259259
</constraints>
260260
<properties>
261261
<text resource-bundle="magento2/common" key="common.cronGroup.description.scheduleLifetime"/>
262262
</properties>
263263
</component>
264264
<component id="47d4e" class="javax.swing.JLabel">
265265
<constraints>
266-
<grid row="6" column="3" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
266+
<grid row="7" column="3" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
267267
</constraints>
268268
<properties>
269269
<text resource-bundle="magento2/common" key="common.cronGroup.description.historyCleanupEvery"/>
270270
</properties>
271271
</component>
272272
<component id="24201" class="javax.swing.JLabel">
273273
<constraints>
274-
<grid row="7" column="3" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
274+
<grid row="8" column="3" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
275275
</constraints>
276276
<properties>
277277
<text resource-bundle="magento2/common" key="common.cronGroup.description.historySuccessLifetime"/>
278278
</properties>
279279
</component>
280280
<component id="28f5e" class="javax.swing.JLabel">
281281
<constraints>
282-
<grid row="8" column="3" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
282+
<grid row="9" column="3" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
283283
</constraints>
284284
<properties>
285285
<text resource-bundle="magento2/common" key="common.cronGroup.description.historyFailureLifetime"/>
286286
</properties>
287287
</component>
288288
<component id="217ce" class="javax.swing.JLabel">
289289
<constraints>
290-
<grid row="9" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
290+
<grid row="10" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
291291
</constraints>
292292
<properties>
293293
<text value="use_separate_process"/>
294294
</properties>
295295
</component>
296296
<component id="e250c" class="javax.swing.JCheckBox" binding="addUseSeparateProcess">
297297
<constraints>
298-
<grid row="9" column="2" row-span="1" col-span="1" vsize-policy="0" hsize-policy="3" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
298+
<grid row="10" column="2" row-span="1" col-span="1" vsize-policy="0" hsize-policy="3" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
299299
</constraints>
300300
<properties>
301301
<selected value="true"/>
@@ -304,23 +304,23 @@
304304
</component>
305305
<component id="4c203" class="javax.swing.JLabel">
306306
<constraints>
307-
<grid row="9" column="3" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
307+
<grid row="10" column="3" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
308308
</constraints>
309309
<properties>
310310
<text resource-bundle="magento2/common" key="common.cronGroup.description.useSeparateProcess"/>
311311
</properties>
312312
</component>
313313
<component id="e05a0" class="javax.swing.JLabel">
314314
<constraints>
315-
<grid row="2" column="3" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
315+
<grid row="3" column="3" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
316316
</constraints>
317317
<properties>
318318
<text resource-bundle="magento2/common" key="common.optionDescription"/>
319319
</properties>
320320
</component>
321321
<component id="8d0ed" class="com.magento.idea.magento2plugin.ui.FilteredComboBox" binding="useSeparateProcess" custom-create="true">
322322
<constraints>
323-
<grid row="9" column="1" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
323+
<grid row="10" column="1" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
324324
</constraints>
325325
<properties>
326326
<toolTipText value=""/>
@@ -331,9 +331,17 @@
331331
</component>
332332
<vspacer id="e9287">
333333
<constraints>
334-
<grid row="1" column="0" row-span="1" col-span="4" vsize-policy="6" hsize-policy="1" anchor="0" fill="2" indent="0" use-parent-layout="false"/>
334+
<grid row="2" column="0" row-span="1" col-span="4" vsize-policy="6" hsize-policy="1" anchor="0" fill="2" indent="0" use-parent-layout="false"/>
335335
</constraints>
336336
</vspacer>
337+
<component id="716d8" class="javax.swing.JLabel" binding="cronGroupNameErrorMessage">
338+
<constraints>
339+
<grid row="1" column="1" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
340+
</constraints>
341+
<properties>
342+
<text value=""/>
343+
</properties>
344+
</component>
337345
</children>
338346
</grid>
339347
</children>

0 commit comments

Comments
 (0)